Skip to content

OLS-3442 Add reasoning token support spec#1782

Open
thoraxe wants to merge 1 commit into
openshift:mainfrom
thoraxe:ols-3442-reasoning-spec
Open

OLS-3442 Add reasoning token support spec#1782
thoraxe wants to merge 1 commit into
openshift:mainfrom
thoraxe:ols-3442-reasoning-spec

Conversation

@thoraxe

@thoraxe thoraxe commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add reasoningConfig field (map[string]interface{}) to ModelParametersSpec in CRD API spec
  • Add reasoning_config serialization to config generation spec
  • Add bedrock to provider type enum
  • Add planned changes for OLS-3442

Context

Companion spec PRs:

Test plan

  • Review reasoningConfig field definition in CRD spec
  • Verify config generation YAML structure includes reasoning_config
  • Confirm bedrock is added to provider type enum

🤖 Generated with Claude Code

Update operator specs for reasoningConfig CRD field on ModelParametersSpec
and reasoning_config serialization in olsconfig.yaml generation. Adds
bedrock to provider type enum.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thoraxe, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e14ddeb4-e60c-4d3d-8ccc-8560108a21ec

📥 Commits

Reviewing files that changed from the base of the PR and between a1bbf9c and f1c26d4.

📒 Files selected for processing (2)
  • .ai/spec/how/config-generation.md
  • .ai/spec/what/crd-api.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from joshuawilson and raptorsun July 3, 2026 14:46
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

@thoraxe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index-lightspeed-bundle-test f1c26d4 link true /test ci-index-lightspeed-bundle-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant