OLS-3221 Reduce app server liveness probe `failureThreshold` from 15 to 3. by sriroopar · Pull Request #1757 · openshift/lightspeed-operator

sriroopar · 2026-06-24T18:24:14Z

Reduce app server liveness probe failureThreshold from 15 to 3, giving the pod 90 seconds to self-heal via the background
health-check loop before Kubernetes restarts it

Add test assertions for failureThreshold: 3 and periodSeconds: 30 to document the 90-second recovery contract

Description

Type of change

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

Bug Fixes
- Adjusted the app server’s liveness check settings to mark unhealthy containers sooner.
- Updated validation to ensure the generated deployment uses the expected liveness probe timing and failure limits.

coderabbitai · 2026-06-24T18:24:26Z

Warning

Review limit reached

@sriroopar, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 4 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d091c41f-23e5-47d2-a9b0-dcabb745ca2a

📥 Commits

Reviewing files that changed from the base of the PR and between a04e330 and ac7df2d.

📒 Files selected for processing (3)

internal/controller/appserver/assets_test.go
internal/controller/appserver/deployment.go
internal/controller/appserver/deployment_test.go

📝 Walkthrough

Walkthrough

The app server deployment lowers the container liveness probe failure threshold from 15 to 3. The associated tests now assert the liveness probe failure threshold and period values in generated deployment output.

Changes

App server liveness probe update

Layer / File(s)	Summary
Liveness probe settings `internal/controller/appserver/deployment.go`, `internal/controller/appserver/deployment_test.go`, `internal/controller/appserver/assets_test.go`	The app server deployment sets the liveness probe `FailureThreshold` to `3`, and tests assert `FailureThreshold: 3` and `PeriodSeconds: 30` in generated deployment output.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely matches the main change: reducing the app server liveness probe failureThreshold from 15 to 3.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Lowers the liveness probe failureThreshold from 15 to 3, giving the pod 90 seconds to self-heal before Kubernetes restarts it. This enables auto-recovery after PostgreSQL restart once the service-side liveness endpoint checks DB health. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

xrajesh · 2026-07-01T21:42:22Z

/lgtm
/approve

openshift-ci · 2026-07-01T21:42:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [xrajesh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-07-02T08:21:33Z

/retest-required

Remaining retests: 0 against base HEAD 7ed4504 and 2 for PR HEAD ac7df2d in total

openshift-merge-bot · 2026-07-03T12:22:28Z

/retest-required

Remaining retests: 0 against base HEAD a1bbf9c and 1 for PR HEAD ac7df2d in total

openshift-merge-bot · 2026-07-06T14:13:06Z

/retest-required

Remaining retests: 0 against base HEAD 9184fd8 and 0 for PR HEAD ac7df2d in total

openshift-ci · 2026-07-06T16:02:42Z

@sriroopar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bundle-e2e-4-21	`ac7df2d`	link	true	`/test bundle-e2e-4-21`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-merge-bot · 2026-07-06T17:41:36Z

/hold

Revision ac7df2d was retested 3 times: holding

openshift-ci Bot requested review from blublinsky and xrajesh June 24, 2026 18:24

sriroopar force-pushed the postgres-auto-recovery branch from a04e330 to ac7df2d Compare June 24, 2026 19:26

openshift-ci Bot assigned xrajesh Jul 1, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OLS-3221 Reduce app server liveness probe `failureThreshold` from 15 to 3.#1757

OLS-3221 Reduce app server liveness probe `failureThreshold` from 15 to 3.#1757
sriroopar wants to merge 1 commit into
openshift:mainfrom
sriroopar:postgres-auto-recovery

sriroopar commented Jun 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

xrajesh commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 3, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 6, 2026

Uh oh!

openshift-ci Bot commented Jul 6, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sriroopar commented Jun 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

xrajesh commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 3, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 6, 2026

Uh oh!

openshift-ci Bot commented Jul 6, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sriroopar commented Jun 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading