Update test#2100
Conversation
📝 WalkthroughWalkthroughThe Tekton integration pipeline updates Playwright container images for lint and e2e tasks, and ChangesPlaywright version alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/integration-tests/lightspeed-console-pre-commit.yaml:
- Line 149: There is a version mismatch between the Playwright Docker image and
the `@playwright/test` package that will cause browser executable issues. The
Docker image reference uses v1.61.0-noble while the package is pinned to 1.60.0.
Update either the `@playwright/test` package version in package.json to 1.61.0 to
match the Docker image, or revert both Docker image references (on lines 149 and
239) from v1.61.0-noble back to v1.60.0 to match the package version. Ensure the
versions are consistent across all references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d6b0d519-9a6a-4c1c-b727-2ed0b6981c94
📒 Files selected for processing (1)
.tekton/integration-tests/lightspeed-console-pre-commit.yaml
8da44ba to
71f051b
Compare
71f051b to
03cea34
Compare
|
/lgtm |
03cea34 to
399f187
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
55-55: 🗄️ Data Integrity & Integration | 🔵 Trivial | 💤 Low valuePatch version mismatch with Tekton Playwright image.
@playwright/testis pinned to1.61.0here, while the Tekton lint/e2e tasks use thev1.61.1-nobleimage. Playwright patch releases can include meaningful fixes (e.g., prior patches have fixed CI-breaking regressions), so aligning both to1.61.1would keep local and CI test runs consistent.♻️ Align npm package with Tekton image tag
- "`@playwright/test`": "1.61.0", + "`@playwright/test`": "1.61.1",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 55, The Playwright dependency version is out of sync with the Tekton Playwright image, so update the `@playwright/test` pin in package.json from 1.61.0 to match the v1.61.1-noble image used by the lint/e2e tasks. Keep the version aligned with the CI image so local and pipeline runs use the same Playwright patch release and stay consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Line 55: The Playwright dependency version is out of sync with the Tekton
Playwright image, so update the `@playwright/test` pin in package.json from 1.61.0
to match the v1.61.1-noble image used by the lint/e2e tasks. Keep the version
aligned with the CI image so local and pipeline runs use the same Playwright
patch release and stay consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a7ed7a46-9480-4e6e-a20f-de03dc7dfd76
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.tekton/integration-tests/lightspeed-console-pre-commit.yamlpackage.json
✅ Files skipped from review due to trivial changes (1)
- .tekton/integration-tests/lightspeed-console-pre-commit.yaml
|
/lgtm |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
399f187 to
c78d794
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
1.60.0→1.61.01.61.1v1.60.0-noble→v1.61.1-nobleRelease Notes
microsoft/playwright (@playwright/test)
v1.61.0Compare Source
🔑 WebAuthn passkeys
New Credentials virtual authenticator, available via browserContext.credentials, lets tests register passkeys and answer
navigator.credentials.create()/navigator.credentials.get()ceremonies in the page — no real hardware key required, works in all browsers:You can also let the app register a passkey once in a setup test, read it back with credentials.get(), and seed it into later tests — see Credentials for details.
🗃️ Web Storage
New WebStorage API, available via page.localStorage and page.sessionStorage, reads and writes the page's storage for the current origin:
New APIs
Network
Browser and Screencast
artifactsDirin browserType.connectOverCDP() controls where artifacts such as traces and downloads are stored when attached to an existing browser.cursorin screencast.showActions() controls the cursor decoration rendered for pointer actions.onFramecallback in screencast.start() now receives atimestampof when the frame was presented by the browser.Test runner
trace: new'on-all-retries','retain-on-first-failure'and'retain-on-failure-and-retries'values. See the video modes table for which runs are recorded and kept in each mode.expect.soft.poll(...).process.argvfrom the runner process, handy for reading custom arguments passed after the--separator.AggregateErroras a separate entry.-Gcommand line shorthand for--grep-invert.🛠️ Other improvements
Browser Versions
This version was also tested against the following stable channels:
Configuration
📅 Schedule: (in timezone UTC)
* * * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.
Summary by CodeRabbit