Skip to content

OLS-3441: Update console spec for script-grounded remediation actions#89

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
vimalk78:ols-3441-script-grounded-rbac
Jul 7, 2026
Merged

OLS-3441: Update console spec for script-grounded remediation actions#89
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
vimalk78:ols-3441-script-grounded-rbac

Conversation

@vimalk78

@vimalk78 vimalk78 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates .ai/spec/what/run-lifecycle.md rules 17, 20, and 22 to reflect OLS-3441 script-grounded RBAC changes
  • Remediation options now contain concrete bash commands (command, type, description) instead of abstract action descriptions
  • RBAC permissions are derived from the script commands rather than predicted independently

Test plan

  • Spec-only change — no code or runtime behavior affected
  • Verify rules 17, 20, 22 align with operator CRD changes in sibling PR

🤖 Generated with Claude Code

Rules 17, 20, 22 now reflect that remediation options contain
concrete bash commands (command, type, description) and RBAC
is derived from those commands rather than predicted independently.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 7, 2026

Copy link
Copy Markdown

@vimalk78: This pull request references OLS-3441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Updates .ai/spec/what/run-lifecycle.md rules 17, 20, and 22 to reflect OLS-3441 script-grounded RBAC changes
  • Remediation options now contain concrete bash commands (command, type, description) instead of abstract action descriptions
  • RBAC permissions are derived from the script commands rather than predicted independently

Test plan

  • Spec-only change — no code or runtime behavior affected
  • Verify rules 17, 20, 22 align with operator CRD changes in sibling PR

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from harche and joshuawilson July 7, 2026 14:04
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8330e0be-dfe9-4d89-a0e0-f37059c43347

📥 Commits

Reviewing files that changed from the base of the PR and between 835eade and b2c515f.

📒 Files selected for processing (1)
  • .ai/spec/what/run-lifecycle.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Clarified the approval and remediation flow for runs, including selecting a remediation option by index and setting retry count.
    • Added clearer guidance that remediation plans should be shown with concrete kubectl/oc commands in the approval view.
    • Expanded the description of remediation options, including ordered actions, permission details, and a stronger warning about privilege limits.

Walkthrough

Documentation-only update to the run lifecycle spec clarifying execution approval requirements and expanding the RemediationOption definition to include structured remediation actions (command, type, description) and RBAC permissions derived from those bash commands.

Changes

Remediation Spec Clarification

Layer / File(s) Summary
Approval and remediation option spec updates
.ai/spec/what/run-lifecycle.md
Clarifies that approving execution selects a remediation option by index with a retry count and displays concrete kubectl/oc bash commands; expands RemediationOption to include ordered actions with command, type, description fields, and states RBAC permissions are derived from those bash commands, locked at approval time, with a danger-level self-escalation alert.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main spec update for script-grounded remediation actions.
Description check ✅ Passed The description matches the spec-only changes to remediation commands and RBAC derivation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@blublinsky

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@blublinsky

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blublinsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ec02e0b into openshift:main Jul 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants