STOR-2961: UPSTREAM: 138768: move VolumeGroupSnapshot to V1 by jsafrane · Pull Request #2715 · openshift/kubernetes

jsafrane · 2026-07-09T12:05:12Z

This is a re-creation of kubernetes#138768. It updates the group snapshot e2e tests to use v1 group snapshot API and also updates the test manifests to use external-snapshotter that actually supports v1.

The upstream PR is waiting for upstream csi-driver-hostpath release, but in the end it should converge to something like this, only with more image bumps.

Summary by CodeRabbit

New Features
- Updated storage snapshot support to use the stable v1 API in end-to-end testing utilities.
- Refreshed snapshotter-sidecar images across CSI test manifests to a newer release.
Bug Fixes
- Improved compatibility for volume group snapshot test coverage by aligning resources with the current API version.

This is a re-creation of kubernetes#138768. It updates the group snapshot e2e tests to use v1 group snapshot API and also updates the test manifests to use external-snapshotter that actually supports v1. The upstream PR needs some changes, but in the end it should converge to this.

openshift-ci-robot · 2026-07-09T12:05:18Z

@jsafrane: This pull request references STOR-2961 which is a valid jira issue.

Details

In response to this:

This is a re-creation of kubernetes#138768. It updates the group snapshot e2e tests to use v1 group snapshot API and also updates the test manifests to use external-snapshotter that actually supports v1.

The upstream PR is waiting for upstream csi-driver-hostpath release, but in the end it should converge to something like this, only with more image bumps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-09T12:05:24Z

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

a4c8c5a|UPSTREAM: 138768: move VolumeGroupSnapshot to V1: the upstream PR kubernetes/kubernetes#138768 has not yet merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

coderabbitai · 2026-07-09T12:05:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73019be3-69fd-4a6b-9a4f-5f93883fd1ba

📥 Commits

Reviewing files that changed from the base of the PR and between a466682 and a4c8c5a.

📒 Files selected for processing (4)

test/e2e/storage/utils/volume_group_snapshot.go
test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/csi-hostpath-plugin.yaml
test/e2e/testing-manifests/storage-csi/hostpath/hostpath/csi-hostpath-plugin.yaml
test/e2e/testing-manifests/storage-csi/mock/csi-mock-driver-snapshotter.yaml

Walkthrough

This PR updates the VolumeGroupSnapshot API version used in e2e storage test utilities from v1beta2 to v1, and bumps the csi-snapshotter sidecar container image tag from v8.4.0 to v8.6.0 in three CSI driver test manifests.

Changes

E2E Storage Version Updates

Layer / File(s)	Summary
VolumeGroupSnapshot API version bump `test/e2e/storage/utils/volume_group_snapshot.go`	`VolumeGroupSnapshotAPIVersion` constant and related GVR variables (snapshots, snapshot classes, snapshot contents) updated from `v1beta2` to `v1`.
csi-snapshotter image bump `test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/csi-hostpath-plugin.yaml`, `test/e2e/testing-manifests/storage-csi/hostpath/hostpath/csi-hostpath-plugin.yaml`, `test/e2e/testing-manifests/storage-csi/mock/csi-mock-driver-snapshotter.yaml`	Container image tag for `csi-snapshotter` sidecar updated from `v8.4.0` to `v8.6.0` in StatefulSet specs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: moving VolumeGroupSnapshot to v1.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only updates helper API versions and manifest images; no Ginkgo It/Describe/Context/When titles were changed.
Test Structure And Quality	✅ Passed	Only API/image version bumps changed; no Ginkgo specs, setup/cleanup, timeout, or assertion-pattern changes were introduced.
Microshift Test Compatibility	✅ Passed	No new Ginkgo test bodies were added; the patch only updates CSI group-snapshot API/version constants and sidecar images, with no MicroShift-unsupported OpenShift API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo specs were added; the PR only updates snapshot API helpers and manifests, with no multi-node/HA assumptions to review.
Topology-Aware Scheduling Compatibility	✅ Passed	Only API/version constants and sidecar image bumps changed; no node selectors, affinity, spread, or control-plane-specific scheduling were introduced.
Ote Binary Stdout Contract	✅ Passed	The PR only bumps API versions and sidecar images; no main/init/TestMain/suite setup or stdout writes were added in top-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only bumps the group-snapshot API version and csi-snapshotter image tags; no new IPv4 literals, host/IP parsing, or connectivity logic was added.
No-Weak-Crypto	✅ Passed	Touched files only change VolumeGroupSnapshot API versions and CSI snapshotter image tags; no weak crypto, custom crypto, or secret comparisons found.
Container-Privileges	✅ Passed	Diff only bumps image tags and group snapshot API versions; no privileged/host* or allowPrivilegeEscalation settings were introduced or changed.
No-Sensitive-Data-In-Logs	✅ Passed	The touched Go file only logs snapshot names, timeouts, and errors; no passwords, tokens, PII, or internal hostnames are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-09T12:09:02Z

@jsafrane: This pull request references STOR-2961 which is a valid jira issue.

Details

In response to this:

This is a re-creation of kubernetes#138768. It updates the group snapshot e2e tests to use v1 group snapshot API and also updates the test manifests to use external-snapshotter that actually supports v1.

The upstream PR is waiting for upstream csi-driver-hostpath release, but in the end it should converge to something like this, only with more image bumps.

Summary by CodeRabbit

New Features

Updated storage snapshot support to use the stable v1 API in end-to-end testing utilities.

Refreshed snapshotter-sidecar images across CSI test manifests to a newer release.

Bug Fixes

Improved compatibility for volume group snapshot test coverage by aligning resources with the current API version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-09T12:09:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign jubittajohn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2026-07-09T12:12:49Z

/payload-job-with-prs help

openshift-ci · 2026-07-09T12:13:11Z

@jsafrane: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

jsafrane · 2026-07-09T12:16:06Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-csi-snapshot-controller-operator#283

openshift-ci · 2026-07-09T12:17:24Z

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6adc880-7b8f-11f1-9158-14ae2cd3eb2e-0

jsafrane · 2026-07-09T12:22:27Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-csi-snapshot-controller-operator#283

openshift-ci · 2026-07-09T12:23:04Z

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9b91ad0-7b90-11f1-8f21-2bd69de242cc-0

jsafrane · 2026-07-09T16:05:25Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-csi-snapshot-controller-operator#283

openshift-ci · 2026-07-09T16:05:36Z

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ffde5490-7baf-11f1-8c92-8b6201752e13-0

jubittajohn · 2026-07-09T16:06:47Z

/retest

jubittajohn · 2026-07-09T17:59:19Z

/retest

jubittajohn · 2026-07-09T20:04:18Z

/test e2e-metal-ipi-ovn-ipv6

rvagner78 · 2026-07-13T14:12:40Z

/test e2e-gcp

openshift-ci · 2026-07-13T15:02:04Z

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-crun	`a4c8c5a`	link	true	`/test e2e-aws-ovn-crun`
ci/prow/e2e-aws-ovn-techpreview	`a4c8c5a`	link	false	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-aws-ovn-fips	`a4c8c5a`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-gcp	`a4c8c5a`	link	true	`/test e2e-gcp`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2026-07-17T12:37:41Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jul 9, 2026

openshift-ci Bot requested review from deads2k and jacobsee July 9, 2026 12:08

jsafrane mentioned this pull request Jul 9, 2026

STOR-3005: Remove v1beta2 group snapshot API openshift/cluster-csi-snapshot-controller-operator#283

Open

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2026

Uh oh!

Conversation

jsafrane commented Jul 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 9, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci-robot commented Jul 9, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

jsafrane commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

jsafrane commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

jsafrane commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

jsafrane commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

jubittajohn commented Jul 9, 2026

Uh oh!

jubittajohn commented Jul 9, 2026

Uh oh!

jubittajohn commented Jul 9, 2026

Uh oh!

rvagner78 commented Jul 13, 2026

Uh oh!

openshift-ci Bot commented Jul 13, 2026

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jsafrane commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 9, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

openshift-ci-robot commented Jul 9, 2026 •

edited by openshift-ci Bot

Loading