DNM: OCPBUGS-90148: Rebase release-4.22 to v1.35.6, want to invesitgate the non-failure of verify-commits#2693
Open
JSampsonIV wants to merge 27 commits into
Open
DNM: OCPBUGS-90148: Rebase release-4.22 to v1.35.6, want to invesitgate the non-failure of verify-commits#2693JSampsonIV wants to merge 27 commits into
JSampsonIV wants to merge 27 commits into
Conversation
When collecting all matching devices for AllocationModeAll, the allocator did not record the source pool on the candidate device. Devices with consumed counters use that pool when checking shared counter availability, which caused kube-scheduler to panic. Set the pool on all-devices candidates in the stable, incubating, and experimental allocators, and add a shared regression test for AllocationModeAll with consumed counters.
When calling ControllerSELinuxTranslator.Conflicts(), the SELinux label is repeatedly split into []string to detect conflicts. This causes a huge number of allocations when there are many comparisons. This is now made more efficient by pre-parsing the SELinux label and storing it in podInfo as [4]string for fast comparison when needed.
Added podToVolumes reverse index to optimize DeletePod. Currently we simply iterate through all the volumes and remove the pod being deleted from there. This is inefficient and takes longer the longer the volume list becomes. Keeping a map pod -> volumes makes removing a pod fast. We can just jump to the relevant volumes directly and remove the pod from there.
Also prevent duplicate metric emissions
Thread the reconciler's existing isRemount signal into MounterArgs so volume plugins can distinguish an initial publish from a republish (e.g. CSIDriver.spec.requiresRepublish=true). No behavior change.
On a remount (e.g. CSIDriver.spec.requiresRepublish=true), the volume is already published and the pod is observing the existing bind mount. Removing the mount dir on a NodePublish error left the pod with stale contents that subsequent successful republishes could not repair.
Accessing svc.Spec.IPFamilies[0] without a bounds check panics when a service reaches the controller with an empty IPFamilies field. This can happen via watch events: the apiserver's defaultOnRead decorator populates IPFamilies on GET/LIST but not on watch (cachingObject wrapping bypasses the type assertion). Restore the inference logic removed in kubernetes#130101: fall back to ClusterIP for headful services and pod IP for headless services. Signed-off-by: Rahul <rahulbabu95@gmail.com>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
[1.35] Restore ability to plumb binary data through envvar values
…selinux-metrics-perf Manual cherry pick selinux metrics perf
…y-pick-of-#138736-upstream-release-1.35 Automated cherry pick of kubernetes#138736: fix: avoid panic on services with empty IPFamilies
…ck-of-#139017-upstream-release-1.35 Automated cherry pick of kubernetes#139017: Fix dra scoring bug with mixed allocated and unallocated claims
…-of-#138885-origin-release-1.35 Automated cherry pick of kubernetes#138885: DRA: fix AllocationModeAll with consumed counters
…ck-of-#139045-upstream-release-1.35 Automated cherry pick of kubernetes#139045: fix(csi): preserve mount dir when NodePublish fails on a remount
…pick-of-#139480-origin-release-1.35 Automated cherry pick of kubernetes#139480: Fix wrong marking of errors
…-pick-of-#139339-upstream-release-1.35 Automated cherry pick of kubernetes#139339: kubeadm: fix dry-run CA copy paths in init certs
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
…l135 [release-1.35] [go]Bump images and versions to go 1.25.11 and distroless iptables
WIP: Rebase v1.35.6
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@JSampsonIV: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JSampsonIV The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@JSampsonIV: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Author
|
/retest |
1 similar comment
Author
|
/retest |
|
/test images |
|
/retest |
|
@JSampsonIV: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
JSampsonIV
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
JSampsonIV
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@JSampsonIV: This pull request references Jira Issue OCPBUGS-77866, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
JSampsonIV
changed the title
|
@JSampsonIV: This pull request references Jira Issue OCPBUGS-90148, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
JSampsonIV
changed the title
Author
|
/hold investigating non-failure of verify-commits |
openshift-ci
Bot
added
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase completed by redhat-chai-bot using script created by JSampsonIV
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: