Skip to content

OCPBUGS-76928: Remove workaround to normalize ISO files extensions#10315

Open
zaneb wants to merge 2 commits intoopenshift:mainfrom
zaneb:no-iso-file-rename
Open

OCPBUGS-76928: Remove workaround to normalize ISO files extensions#10315
zaneb wants to merge 2 commits intoopenshift:mainfrom
zaneb:no-iso-file-rename

Conversation

@zaneb
Copy link
Member

@zaneb zaneb commented Feb 16, 2026

Use the latest version of go-diskfs that generates the short filenames in ISO 9660 Level 1 format internally.

This pulls in the latest version of go-diskfs, which has the effect of
naming files added to an ISO with the ISO 9660 Level 1 short filenames
(8.3) generated by default in xorriso, and expected by coreos-installer.
Now that go-diskfs generates the short filenames in ISO9660 Level 1
format, we don't need to work around it by modifying the long filenames.
This should make the ISO look more like the original CoreOS one.

This reverts commit d3ffa4f.
This reverts commit 6748cdd.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 16, 2026
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-76928, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Use the latest version of go-diskfs that generates the short filenames in ISO 9660 Level 1 format internally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 16, 2026
@andfasano
Copy link
Contributor

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026
@andfasano
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-vendor b2bbf9c link true /test verify-vendor
ci/prow/verify-deps b2bbf9c link true /test verify-deps
ci/prow/artifacts-images b2bbf9c link true /test artifacts-images
ci/prow/e2e-agent-two-node-fencing-ipv4 b2bbf9c link false /test e2e-agent-two-node-fencing-ipv4
ci/prow/e2e-agent-compact-ipv6-minimaliso b2bbf9c link false /test e2e-agent-compact-ipv6-minimaliso
ci/prow/govet b2bbf9c link true /test govet
ci/prow/okd-scos-images b2bbf9c link true /test okd-scos-images
ci/prow/e2e-agent-sno-ipv6 b2bbf9c link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-4control-ipv4 b2bbf9c link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-sno-ipv4-pxe b2bbf9c link false /test e2e-agent-sno-ipv4-pxe
ci/prow/e2e-agent-5control-ipv4 b2bbf9c link false /test e2e-agent-5control-ipv4
ci/prow/verify-codegen b2bbf9c link true /test verify-codegen
ci/prow/images b2bbf9c link true /test images
ci/prow/integration-tests-nodejoiner b2bbf9c link true /test integration-tests-nodejoiner
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage b2bbf9c link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/unit b2bbf9c link true /test unit
ci/prow/e2e-aws-ovn b2bbf9c link true /test e2e-aws-ovn
ci/prow/e2e-agent-ha-dualstack b2bbf9c link false /test e2e-agent-ha-dualstack
ci/prow/integration-tests b2bbf9c link true /test integration-tests
ci/prow/e2e-agent-compact-ipv4-none-platform b2bbf9c link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/golint b2bbf9c link true /test golint
ci/prow/e2e-agent-compact-ipv4-iso-no-registry b2bbf9c link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-agent-compact-ipv4 b2bbf9c link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zaneb
Copy link
Member Author

zaneb commented Feb 17, 2026

go get insisted on updating to go 1.25, which evidently we don't have yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants