Bug 10108: Copy LoadBalancer config to AgentClusterInstall for BareMetal platform#10309
Open
mpmprock3 wants to merge 1 commit intoopenshift:release-4.21from
Open
Bug 10108: Copy LoadBalancer config to AgentClusterInstall for BareMetal platform#10309mpmprock3 wants to merge 1 commit intoopenshift:release-4.21from
mpmprock3 wants to merge 1 commit intoopenshift:release-4.21from
Conversation
…tal platform When using platform: baremetal with loadBalancer: type: UserManaged, the LoadBalancer configuration was not being copied to the AgentClusterInstall manifest. This caused assisted-service to fail validation when using the same VIP for both API and Ingress. Fixes: openshift#10108
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@mpmprock3: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #10108 where the
loadBalancerconfiguration frominstall-config.yamlwasnot being copied to the
AgentClusterInstallmanifest during agent ISO creation.When deploying an OpenShift cluster with
platform: baremetalandloadBalancer: type: UserManaged, users should be able to use the same VIP address for both API and Ingress. Theinstaller correctly validates this configuration and generates the ISO, but the
assisted-servicerunning on the booted node fails validation because it checks the
AgentClusterInstallmanifestfor the
loadBalancerconfiguration which was missing.Changes
LoadBalancerconfiguration frominstall-config.yamltoAgentClusterInstall.Spec.LoadBalancerfor BareMetal platformconvertLoadBalancerType()helper function to convert betweenconfigv1.PlatformLoadBalancerTypeandhiveext.LoadBalancerTypeTesting
agent-cluster-install.yamlnow includesloadBalancer: type: UserManagedFixes: #10108