Bug 10108: Copy LoadBalancer config to AgentClusterInstall for BareMetal platform#10306
Bug 10108: Copy LoadBalancer config to AgentClusterInstall for BareMetal platform#10306mpmprock3 wants to merge 1 commit intoopenshift:mainfrom
Conversation
…tal platform When using platform: baremetal with loadBalancer: type: UserManaged, the LoadBalancer configuration was not being copied to the AgentClusterInstall manifest. This caused assisted-service to fail validation when using the same VIP for both API and Ingress. Fixes: openshift#10108
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mpmprock3: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR fixes issue #10108 where the
loadBalancerconfiguration frominstall-config.yamlwasnot being copied to the
AgentClusterInstallmanifest during agent ISO creation.When deploying an OpenShift cluster with
platform: baremetalandloadBalancer: type: UserManaged, users should be able to use the same VIP address for both API and Ingress. Theinstaller correctly validates this configuration and generates the ISO, but the
assisted-servicerunning on the booted node fails validation because it checks the
AgentClusterInstallmanifestfor the
loadBalancerconfiguration which was missing.Changes
LoadBalancerconfiguration frominstall-config.yamltoAgentClusterInstall.Spec.LoadBalancerfor BareMetal platformconvertLoadBalancerType()helper function to convert betweenconfigv1.PlatformLoadBalancerTypeandhiveext.LoadBalancerTypeTesting
agent-cluster-install.yamlnow includesloadBalancer: type: UserManagedFixes: #10108