CORS-4055: migrate Route53 API calls to AWS SDK v2 by tthvo · Pull Request #10265 · openshift/installer

tthvo · 2026-01-28T04:38:05Z

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route 53 clients in the pkg/asset and dependent pkg(s).

This PR contains quite a lot refactoring in order to follow the AWS SDK v2 client pattern.

openshift-ci-robot · 2026-01-28T04:38:09Z

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route 53 clients in the pkg/asset and dependent pkg(s).

This PR contains quite a lot refactoring in order to follow the AWS SDK v2 client pattern.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-01-28T04:39:10Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-01-28T04:39:27Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a5f5af0-fc03-11f0-867f-09e93b4dd687-0

tthvo · 2026-01-28T04:40:14Z

/label tide/merge-method-squash

tthvo · 2026-01-28T04:40:36Z

/label platform/aws

/cc @barbacbd @yunjiang29

tthvo · 2026-01-28T14:54:46Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-01-28T14:55:15Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a588710-fc59-11f0-99ed-1e5f7c9cd027-0

tthvo · 2026-01-28T15:16:32Z

/test golint

tthvo · 2026-01-28T15:35:54Z

/test golint

flakes?

tthvo · 2026-01-28T19:59:21Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-01-28T19:59:26Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6b3fa80-fc83-11f0-8ca4-51e4c7d2cbe0-0

pkg/asset/installconfig/aws/route53.go

pkg/asset/installconfig/platformprovisioncheck.go

tthvo · 2026-01-29T21:43:45Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-01-29T21:43:50Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96b32720-fd5b-11f0-9d65-0f8c8c4b3605-0

barbacbd

/approve

openshift-ci · 2026-01-30T11:44:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [barbacbd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tthvo · 2026-01-30T20:42:32Z

/test artifacts-images

tthvo · 2026-02-03T02:12:19Z

/verified by presubmit and payload testing

openshift-ci · 2026-02-06T20:52:36Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c12285d0-039d-11f1-8493-5bfb26f034e7-0

tthvo · 2026-02-06T20:53:06Z

I think this PR will conflict with #10262 again in the module.txt. Maybe let's get this one in first...?

tthvo · 2026-02-06T21:22:01Z

I think this PR will conflict with #10262 again in the module.txt. Maybe let's get this one in first...?

I guess either merge order is fine, but it must be one after another :D

openshift-ci · 2026-02-06T23:54:18Z

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-edge-zones	`9665cf1`	link	false	`/test e2e-aws-ovn-edge-zones`
ci/prow/e2e-aws-ovn-dualstack-ipv4-primary-techpreview	`9665cf1`	link	false	`/test e2e-aws-ovn-dualstack-ipv4-primary-techpreview`
ci/prow/e2e-aws-ovn-fips	`9665cf1`	link	false	`/test e2e-aws-ovn-fips`
ci/prow/aws-private	`9665cf1`	link	false	`/test aws-private`
ci/prow/e2e-aws-ovn-heterogeneous	`9665cf1`	link	false	`/test e2e-aws-ovn-heterogeneous`
ci/prow/e2e-aws-ovn-single-node	`9665cf1`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/artifacts-images	`9665cf1`	link	true	`/test artifacts-images`
ci/prow/images	`9665cf1`	link	true	`/test images`
ci/prow/e2e-aws-ovn	`9665cf1`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones	`9665cf1`	link	false	`/test e2e-aws-ovn-shared-vpc-edge-zones`
ci/prow/e2e-aws-ovn-imdsv2	`9665cf1`	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/e2e-aws-default-config	`9665cf1`	link	false	`/test e2e-aws-default-config`
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups	`9665cf1`	link	false	`/test e2e-aws-ovn-shared-vpc-custom-security-groups`
ci/prow/e2e-aws-ovn-dualstack-ipv6-primary-techpreview	`9665cf1`	link	false	`/test e2e-aws-ovn-dualstack-ipv6-primary-techpreview`
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation	`9665cf1`	link	true	`/test e2e-aws-ovn-edge-zones-manifest-validation`
ci/prow/e2e-aws-byo-subnet-role-security-groups	`9665cf1`	link	false	`/test e2e-aws-byo-subnet-role-security-groups`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tthvo · 2026-02-10T02:32:15Z

/hold

Investigating if this breaks compatibility with China's partition.... 👇

installer/pkg/asset/installconfig/aws/session.go

Line 278 in 36f2373

func defaultEndpoints() map[string]map[string]endpoints.ResolvedEndpoint {

tthvo · 2026-02-10T03:34:28Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-usgov-ipi-private-ep-fips-f7

openshift-ci · 2026-02-10T03:34:34Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-usgov-ipi-private-ep-fips-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/67c4f040-0631-11f1-9c7a-c0ae8b9bfc9b-0

tthvo · 2026-02-10T03:35:24Z

/retest

The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route53 clients in the pkg/asset and dependent pkg(s).

tthvo · 2026-02-10T17:20:59Z

/hold cancel

Investigating if this breaks compatibility with China's partition.... 👇

Confirmed with @yunjiang29 that there is no compatibility breaking for China regions.

tthvo · 2026-02-10T17:22:07Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-usgov-ipi-private-ep-fips-f7

openshift-ci · 2026-02-10T17:22:18Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-usgov-ipi-private-ep-fips-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07195ff0-06a5-11f1-9d2a-db7444b74f09-0

tthvo · 2026-02-10T17:22:38Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-02-10T17:22:57Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19b181b0-06a5-11f1-9c18-9f7616fe49f5-0

gpei · 2026-02-12T00:46:10Z

/jira cc-qa

openshift-ci-robot · 2026-02-12T00:46:15Z

@gpei: This pull request references CORS-4055 which is a valid jira issue.

Requesting review from QA contact:
/cc @yunjiang29

Details

In response to this:

/jira cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2026-02-12T00:46:34Z

/jira refresh

openshift-ci-robot · 2026-02-12T00:46:38Z

@gpei: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2026-02-12T00:53:17Z

@gpei: This pull request references CORS-4055 which is a valid jira issue.

Requesting review from QA contact: /cc @yunjiang29

Details

Cool, looks like the command /jira cc-qa is working with the CORS issues now.

@tthvo Sorry for the noise. I just happened to open this PR and wanted to test if /jira cc-qa command can automatically request QA reviews.

tthvo · 2026-02-12T00:57:22Z

Oh, no worries at all! This command is pretty cool 😎

tthvo · 2026-02-12T00:59:17Z

/test okd-scos-images

gpei · 2026-02-12T01:05:24Z

Oh, no worries at all! This command is pretty cool 😎

Yes, this command can also be used for PRs linked to OCPBUGS issues. I just tried it here - #10296 (comment), and it works, but it seems there's a prerequisite: the issue itself must be a valid issue.

tthvo · 2026-02-14T05:00:01Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

openshift-ci · 2026-02-14T05:00:07Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-openldap-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/05053b70-0962-11f1-8faf-4a4309c5c2e8-0

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026

openshift-ci bot requested review from mtulio and patrickdillon January 28, 2026 04:38

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 28, 2026

openshift-ci bot requested review from barbacbd and yunjiang29 January 28, 2026 04:40

openshift-ci bot added the platform/aws label Jan 28, 2026

tthvo force-pushed the CORS-4055-route53 branch from 2d3d52e to dcdd3d7 Compare January 28, 2026 14:54

tthvo force-pushed the CORS-4055-route53 branch from dcdd3d7 to 64a0786 Compare January 28, 2026 19:18

barbacbd reviewed Jan 29, 2026

View reviewed changes

pkg/asset/installconfig/aws/route53.go Outdated Show resolved Hide resolved

pkg/asset/installconfig/platformprovisioncheck.go Show resolved Hide resolved

tthvo force-pushed the CORS-4055-route53 branch from 64a0786 to f39a9fe Compare January 29, 2026 21:43

barbacbd reviewed Jan 30, 2026

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 3, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026

tthvo added 3 commits February 10, 2026 09:10

CORS-4055: migrate Route53 API calls to AWS SDK v2

772608c

The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on Route53 clients in the pkg/asset and dependent pkg(s).

tests: regenerate asset test mocks

6443433

vendor: update vendor

5b16232

tthvo force-pushed the CORS-4055-route53 branch from 9665cf1 to 5b16232 Compare February 10, 2026 17:19

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026

tthvo mentioned this pull request Feb 13, 2026

CORS-4336: Support for AWS European Sovereign Cloud #10303

Open

Conversation

tthvo commented Jan 28, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

openshift-ci bot commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

openshift-ci bot commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

openshift-ci bot commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

tthvo commented Jan 29, 2026

Uh oh!

openshift-ci bot commented Jan 29, 2026

Uh oh!

barbacbd left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

tthvo commented Jan 30, 2026

Uh oh!

tthvo commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 6, 2026

Uh oh!

tthvo commented Feb 6, 2026

Uh oh!

tthvo commented Feb 6, 2026

Uh oh!

openshift-ci bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

openshift-ci bot commented Feb 10, 2026

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

openshift-ci bot commented Feb 10, 2026

Uh oh!

tthvo commented Feb 10, 2026

Uh oh!

openshift-ci bot commented Feb 10, 2026

Uh oh!

gpei commented Feb 12, 2026

Uh oh!

openshift-ci-robot commented Feb 12, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Feb 12, 2026

Uh oh!

openshift-ci-robot commented Feb 12, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Feb 12, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Feb 6, 2026 •

edited

Loading

openshift-ci-robot commented Feb 12, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2026 •

edited by openshift-ci bot

Loading