OTA-1546: Add a serial e2e for accept-risks

[hongkailiu]

No description provided.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

/test all

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

/test images

[hongkailiu]

/test all

[hongkailiu]

/test images

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

The new test case passed in this job which is failed on other case:

$ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1310/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial/2021749396105859072/artifacts/e2e-agnostic-ovn-techpreview-serial/openshift-e2e-test/artifacts/e2e.log" | grep 'accept risks'
started: 0/88/111 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks [Serial]"
passed: (4m1s) 2026-02-12T05:33:44 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks [Serial]"

/test all

/verified by @hongkailiu

[openshift-ci-robot]

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

The new test case passed in this job which is failed on other case:

$ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1310/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial/2021749396105859072/artifacts/e2e-agnostic-ovn-techpreview-serial/openshift-e2e-test/artifacts/e2e.log" | grep 'accept risks'
started: 0/88/111 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks [Serial]"
passed: (4m1s) 2026-02-12T05:33:44 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks [Serial]"

/test all

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JianLi-RH]

There are some minor suggestions from AI (I'd like suggestion 2 because you created a single file for accept -risks):

Minor

1. Naming inconsistency: In pkg/external/constants.go, the constant name ConditionalUpdateConditionTypeRecommended is quite verbose. While accurate, it might benefit from the context of being in a constants package (could just be RecommendedConditionType). However, this is subjective and the current naming is clear.

2. Documentation: The test file test/cvo/accept_risks.go lacks a package-level comment explaining what this test validates and why it's serial. Consider adding:

// Package cvo contains end-to-end tests for the Cluster Version Operator.
// The accept_risks test validates the conditional update risk acceptance workflow.

3. Magic numbers: The polling intervals in test/cvo/accept_risks.go:73 (30time.Second, 5time.Minute) could be extracted as constants for better maintainability:

const (
    pollInterval = 30 * time.Second
    pollTimeout  = 5 * time.Minute
)

[hongkailiu]

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

I need to verify if the Qualifiers still work for BOTH cases.

[hongkailiu]

For e2e-agnostic-ovn: It contains the non-serial test cases:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1310/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/2022445338412978176/artifacts/e2e-agnostic-ovn/openshift-e2e-test/artifacts/e2e.log | grep '\[Jira:\\"Cluster Version Operator\\"\]'
started: 0/112/429 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should have correct runlevel and scc"
passed: (200ms) 2026-02-14T01:15:39 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should have correct runlevel and scc"
started: 1/284/429 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing tests"
passed: (0s) 2026-02-14T01:18:18 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing tests"
started: 1/287/429 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests can use oc to get the version information"
passed: (100ms) 2026-02-14T01:18:20 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests can use oc to get the version information"

The serial job failed at pre. let us try again.

/test e2e-agnostic-ovn-techpreview-serial

[hongkailiu]

e2e-agnostic-ovn-techpreview-serial has the only serial test cases:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1310/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial/2022503081538752512/artifacts/e2e-agnostic-ovn-techpreview-serial/openshift-e2e-test/artifacts/e2e.log | grep '\[Jira:\\"Cluster Version Operator\\"\]'
started: 0/1/111 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks"
passed: (3m30s) 2026-02-14T06:00:12 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks"
started: 0/10/111 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing serial tests [Serial]"
passed: (0s) 2026-02-14T06:04:49 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing serial tests [Serial]"

It failed on other cases which seems irrelevant to this pull.

/hold cancel

/retest-required

[hongkailiu]

/verified cancel

[openshift-ci-robot]

@hongkailiu: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

There are some minor suggestions from AI (I'd like suggestion 2 because you created a single file for accept -risks):

Minor

1. Naming inconsistency: In pkg/external/constants.go, the constant name ConditionalUpdateConditionTypeRecommended is quite verbose. While accurate, it might benefit from the context of being in a constants package (could just be RecommendedConditionType). However, this is subjective and the current naming is clear.
2. Documentation: The test file test/cvo/accept_risks.go lacks a package-level comment explaining what this test validates and why it's serial. Consider adding:

// Package cvo contains end-to-end tests for the Cluster Version Operator.
// The accept_risks test validates the conditional update risk acceptance workflow.

3. Magic numbers: The polling intervals in test/cvo/accept_risks.go:73 (30_time.Second, 5_time.Minute) could be extracted as constants for better maintainability:

const (
    pollInterval = 30 * time.Second
    pollTimeout  = 5 * time.Minute
)

1 is a good point but the names are not introduced by this pull. We could do it with another pull to keep this one small.
2 is done with 993d5e5
3 I did not make the constants because they might be different for other polling functions.

[JianLi-RH]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, JianLi-RH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hongkailiu]

/hold

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

/retest-required

[openshift-ci]

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.