Skip to content

[release-6.4]feat: make terminationGracePeriodSeconds configurable via field of CollectorSpec#3342

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-6.4from
vparfonov:log9640
Jul 8, 2026
Merged

[release-6.4]feat: make terminationGracePeriodSeconds configurable via field of CollectorSpec#3342
openshift-merge-bot[bot] merged 1 commit into
openshift:release-6.4from
vparfonov:log9640

Conversation

@vparfonov

Copy link
Copy Markdown
Contributor

Description

/cc @Clee2691
/assign @jcantrill

Links

…llectorSpec

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci openshift-ci Bot requested a review from Clee2691 July 8, 2026 13:24
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3cbb882d-467c-45d2-b5bc-56e8712f3233

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vparfonov vparfonov changed the title feat: make terminationGracePeriodSeconds configurable via field of CollectorSpec [release-6.4]feat: make terminationGracePeriodSeconds configurable via field of CollectorSpec Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcantrill jcantrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 7eace64 into openshift:release-6.4 Jul 8, 2026
9 checks passed
@vparfonov vparfonov deleted the log9640 branch July 8, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants