Skip to content

STOR-3005: Update group snapshot CRDs to offer only v1 API#281

Open
rvagner78 wants to merge 1 commit into
openshift:mainfrom
rvagner78:stor-3005
Open

STOR-3005: Update group snapshot CRDs to offer only v1 API#281
rvagner78 wants to merge 1 commit into
openshift:mainfrom
rvagner78:stor-3005

Conversation

@rvagner78

@rvagner78 rvagner78 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates
    • Volume group snapshot APIs promoted to stable v1 version
    • Beta API versions (v1beta1, v1beta2) no longer supported
    • Webhook configurations updated to use v1 API version
    • Users must migrate existing configurations to v1 API

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This pull request references STOR-3005 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6a3e01cf-3aa4-427e-917f-af6832249323

📥 Commits

Reviewing files that changed from the base of the PR and between ed3c0c6 and 38e598a.

📒 Files selected for processing (4)
  • assets/volumegroupsnapshotclasses.yaml
  • assets/volumegroupsnapshotcontents.yaml
  • assets/volumegroupsnapshots.yaml
  • assets/webhook_config.yaml

Walkthrough

This PR migrates custom resource definitions and webhook configuration from beta/alpha API versions to v1. Three CRD files transition from v1beta2 to v1, with comment and version name updates. One CRD schema field is clarified by removing version-specific phrasing. Webhook configuration is updated to support v1.

Changes

API Version Migration to v1

Layer / File(s) Summary
CRD version name migrations and guidance comments
assets/volumegroupsnapshotclasses.yaml, assets/volumegroupsnapshotcontents.yaml, assets/volumegroupsnapshots.yaml
Three CRD spec.versions[].name entries changed from v1beta2 to v1. Inline comments updated to specify that OCP must use only v1 and that beta versions are not offered.
Schema field documentation cleanup
assets/volumegroupsnapshotcontents.yaml
VolumeSnapshotInfoList field description rewritten to remove v1beta2-specific phrasing about replacement and introduction, with reformatted text.
Webhook configuration alignment
assets/webhook_config.yaml
volumegroupsnapshotclasses webhook apiVersions list updated from v1alpha1 to v1.

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change across all modified files: updating group snapshot CRDs (volumegroupsnapshotclasses, volumegroupsnapshotcontents, volumegroupsnapshots) from v1beta2 to v1 as the only offered API version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #281 modifies only CRD YAML assets (no *_test.go / Ginkgo specs changed), so no Ginkgo test titles with dynamic values were introduced.
Test Structure And Quality ✅ Passed PR #281 changes only CRD asset YAML files (4 total) and contains no Ginkgo test code updates, so the test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed PR only updates CRD/Webhook YAML assets; no Ginkgo e2e tests appear in the repo (no ginkgo usage found), so MicroShift compatibility check isn’t triggered.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR commit diff changes only assets CRD/YAML files; git diff shows no changes under test/ (incl. test/e2e), so no new Ginkgo e2e tests to assess for SNO compatibility.
Topology-Aware Scheduling Compatibility ✅ Passed PR #281 changes only group snapshot CRD YAML/comments/version names; no scheduling constraints (affinity/nodeSelector/topologySpread/PDB/replica logic) were added to manifests or operator code.
Ote Binary Stdout Contract ✅ Passed PR #281 changes only CRD asset YAML files (4 total) and contains no Go/process-level main/TestMain/RunSpecs stdout/logging code changes that could corrupt OTE JSON stdout. citeturn2view0
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #281 only updates CRD/webhook YAML assets (4 files); no new Ginkgo e2e tests (no It/Describe/Context) were added, so no IPv4/Internet assumptions to flag.
No-Weak-Crypto ✅ Passed PR #281 only updates CRD/webhook YAML (v1 API version comments/names). Searches in changed assets for MD5/SHA1/DES/RC4/3DES/Blowfish/ECB found no matches; no crypto code/comparisons present.
Container-Privileges ✅ Passed PR #281 only updates CRD/webhook YAMLs (assets/volumegroupsnapshotclasses.yaml, contents.yaml, snapshots.yaml, webhook_config.yaml). Searches on the PR diff show no hostPID/hostNetwork/hostIPC/SYS_...
No-Sensitive-Data-In-Logs ✅ Passed PR #281 only changes four CRD/webhook YAML assets; inspection of the PR files shows no sensitive logging strings (e.g., no password/token/apiKey/PII) in the diff content.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from RomanBednar and rhrmo June 12, 2026 12:16
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rvagner78
Once this PR has been reviewed and has the lgtm label, please assign dfajmon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-aws-e2e-external 38e598a link true /test hypershift-aws-e2e-external

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2026
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants