Skip to content

OCPBUGS-114428: Update build-machinery-go vendor dependency - #146

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:update-build-machinery-go
Open

OCPBUGS-114428: Update build-machinery-go vendor dependency#146
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:update-build-machinery-go

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 10, 2026

Copy link
Copy Markdown

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Summary by CodeRabbit

  • Chores
    • Updated the application’s underlying build environment and supporting components.
    • No changes to user-facing functionality, behavior, or public interfaces.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5c0f6095-3a8d-45bc-aab7-2df61fdb6c55

📥 Commits

Reviewing files that changed from the base of the PR and between c524fd0 and 6d65ef3.

⛔ Files ignored due to path filters (26)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/build-machinery-go/.ci-operator.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/AGENTS.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/ARCHITECTURE.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/CLAUDE.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/Dockerfile.commitchecker is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/OWNERS is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/OWNERS_ALIASES is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/default.example.mk.help.log is excluded by !**/*.log, !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/golang.example.mk.help.log is excluded by !**/*.log, !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/lib/golang.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/operator.example.mk.help.log is excluded by !**/*.log, !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/golang/test-unit.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/golang/verify-update.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/golang/version.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/golang/vulncheck.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/openshift/controller-gen.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/openshift/images.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/openshift/operator/mom.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/openshift/yq.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/scripts/test-operator-integration.sh is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/scripts/vulncheck.sh is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Go module now targets Go 1.22.0. The github.com/openshift/build-machinery-go dependency now uses a newer pseudo-version. Other module requirements remain unchanged.

Changes

Go module baseline

Layer / File(s) Summary
Go version and dependency update
go.mod
The Go directive changed from go 1.19 to go 1.22.0. The github.com/openshift/build-machinery-go dependency changed to a newer pseudo-version.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6d65e

The reviewed module baseline update has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: updating the build-machinery-go vendor dependency. It also includes the related issue identifier.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The authoritative PR diff changes 27 files, but no Go source or test files. The only test-related change is the vendored make/targets/golang/test-unit.mk build script. Searches of added diff l…
Test Structure And Quality ✅ Passed The custom check is not applicable to this pull request. The authoritative diff changes go.mod, go.sum, vendor metadata, and build-machinery-go tooling, but no Go source or test paths. The patch conta…
Microshift Test Compatibility ✅ Passed The pull request adds no Ginkgo or Go test files. The authoritative diff changes go.mod, go.sum, vendor/modules.txt, and vendored build-machinery-go metadata, makefiles, and scripts. No new It(), Desc…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only go.mod, go.sum, vendor metadata, documentation, Makefiles, and shell scripts. It adds no Go files, test files, or Ginkgo declarations such as It(), Describe(), Context(),…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request does not add or modify deployment manifests, operator code, or controllers. The authoritative diff changes go.mod/go.sum, vendor metadata, build Makefiles, CI build-image config…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only module metadata and vendored build-machinery make/scripts/docs; it changes no Go source files. The repository builds cluster-bootstrap, not an OpenShift Tests Ext…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds no new Ginkgo e2e tests. The authoritative diff changes go.mod, go.sum, vendor metadata, documentation, Make fragments, and shell scripts. No changed or added .go test files cont…
No-Weak-Crypto ✅ Passed PASS. The review-scoped diff changes go.mod/go.sum, vendor metadata, and build-machinery Makefile/shell/documentation files. It adds no Go source files. Added-line searches found no MD5, SHA-1, DES, 3…
Container-Privileges ✅ Passed PASS. The pull request changes Go module metadata and vendored build-machinery files. The changed CI YAML only updates the build image tag. The added Dockerfile contains no privileged, hostPID, `h…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The reviewed range updates Go metadata and vendors build-machinery-go files. No changed Go logging code or literal passwords, tokens, API keys, PII, hostnames, or customer data were found. The n…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Summary by CodeRabbit

  • Chores
  • Updated the application’s underlying build environment and supporting components.
  • No changes to user-facing functionality, behavior, or public interfaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ricardomaraschini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Author

/retest


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 6d65ef3 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants