Skip to content

Ignoring chai-bot-s3-reader user to be nuked#669

Open
ravitri wants to merge 1 commit into
openshift-online:mainfrom
ravitri:update-nuke-chai
Open

Ignoring chai-bot-s3-reader user to be nuked#669
ravitri wants to merge 1 commit into
openshift-online:mainfrom
ravitri:update-nuke-chai

Conversation

@ravitri

@ravitri ravitri commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Adding chai-bot-s3-reader IAM user to the ignore list as well for janitor job.

Summary by CodeRabbit

  • Chores
    • Updated cleanup rules to keep an additional CI-related IAM user and its access keys from being removed during automated environment cleanup.

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cdoan1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fd809f27-4610-4739-a876-f647dbf0388b

📥 Commits

Reviewing files that changed from the base of the PR and between 1c55ea5 and 14b8bdb.

📒 Files selected for processing (1)
  • ci/janitor/aws-nuke-config.yaml

📝 Walkthrough

Walkthrough

The ci preset's IAM user preservation list in the aws-nuke-config.yaml janitor configuration is expanded to include the chai-bot-s3-reader identity, with a matching IAMUserAccessKey filter entry added under the ci-user-filters anchor.

Changes

AWS Nuke Config Update

Layer / File(s) Summary
Add chai-bot-s3-reader to ci preset filters
ci/janitor/aws-nuke-config.yaml
The ci preset's IAM user inclusion list and IAMUserAccessKey filters are updated to preserve the chai-bot-s3-reader identity alongside existing e2e and ci users.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: ci, configuration

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: preserving the chai-bot-s3-reader IAM user from janitor deletion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@ravitri

ravitri commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/test unit-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant