Skip to content

Add Grafana ingress Terraform module with ALB, DNS, and ACM cert#652

Open
iamkirkbater wants to merge 6 commits into
openshift-online:mainfrom
iamkirkbater:grafana-ingress-sso
Open

Add Grafana ingress Terraform module with ALB, DNS, and ACM cert#652
iamkirkbater wants to merge 6 commits into
openshift-online:mainfrom
iamkirkbater:grafana-ingress-sso

Conversation

@iamkirkbater

Copy link
Copy Markdown
Contributor

Adds an ingress and DNS for grafana, and wires up the correct config to use the SSO.

iamkirkbater and others added 5 commits June 25, 2026 14:09
Internet-facing ALB in public subnets with TLS termination, Route53
alias record (grafana.<deployment>.<domain>), and security groups.
Gated behind enable_grafana_ingress feature flag (enabled for
integration). Cluster-side auth proxy will follow in a separate branch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Using native Grafana OIDC auth instead of oauth2-proxy, so the ALB
targets Grafana pods directly. Changes target group port from 4180
to 3000, health check from /ping to /api/health, and updates
security group descriptions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@iamkirkbater, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 50 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 817b1b67-4761-4c53-87a0-0812ec25558c

📥 Commits

Reviewing files that changed from the base of the PR and between 337be0f and 2b6af78.

📒 Files selected for processing (30)
  • argocd/config/regional-cluster/grafana/templates/auth-anonymous.yaml
  • argocd/config/regional-cluster/grafana/templates/auth-sso.yaml
  • argocd/config/regional-cluster/grafana/templates/sso-external-secret.yaml
  • argocd/config/regional-cluster/grafana/templates/targetgroupbinding.yaml
  • argocd/config/regional-cluster/grafana/values.yaml
  • config/defaults.yaml
  • config/integration/defaults.yaml
  • config/templates/argocd-bootstrap/applicationset.yaml.j2
  • config/templates/pipeline-regional-cluster-inputs/terraform.json.j2
  • deploy/ephemeral/us-east-1/_merged_config.yaml
  • deploy/ephemeral/us-east-1/argocd-bootstrap-management-cluster/applicationset.yaml
  • deploy/ephemeral/us-east-1/argocd-bootstrap-regional-cluster/applicationset.yaml
  • deploy/ephemeral/us-east-1/pipeline-regional-cluster-inputs/terraform.json
  • deploy/integration/us-east-1/_merged_config.yaml
  • deploy/integration/us-east-1/argocd-bootstrap-management-cluster/applicationset.yaml
  • deploy/integration/us-east-1/argocd-bootstrap-regional-cluster/applicationset.yaml
  • deploy/integration/us-east-1/pipeline-regional-cluster-inputs/terraform.json
  • docs/environment-provisioning.md
  • scripts/bootstrap-argocd.sh
  • terraform/config/regional-cluster/main.tf
  • terraform/config/regional-cluster/outputs.tf
  • terraform/config/regional-cluster/variables.tf
  • terraform/modules/ecs-bootstrap/main.tf
  • terraform/modules/grafana-ingress/acm.tf
  • terraform/modules/grafana-ingress/dns.tf
  • terraform/modules/grafana-ingress/main.tf
  • terraform/modules/grafana-ingress/outputs.tf
  • terraform/modules/grafana-ingress/security-groups.tf
  • terraform/modules/grafana-ingress/variables.tf
  • terraform/modules/grafana-ingress/versions.tf
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant