Test latest hyperfleet versions#596
Open
typeid wants to merge 9 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Collaborator
Author
|
/test on-demand-e2e |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBumps Hyperfleet charts to v0.3.0, switches container images to quay.io/redhat-services-prod/hyperfleet-tenant/hyperfleet:latest, changes sentinel repo, comments out adapter version, and adds RabbitMQ routing (queue/exchange/routingKey) for adapter1 and sentinel. ChangesHyperfleet Components Upgrade
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Suggested labels
Suggested Reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Switch all three hyperfleet components to v0.3.0 charts and use production image registry. Also moves sentinel chart source from personal fork to the upstream openshift-hyperfleet org repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
/test on-demand-e2e |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yaml`:
- Around line 18-20: The image tag is pinned to "latest" and pullPolicy is set
to Always; update the template values for registry/repository/tag and the
container pullPolicy used by the hyperfleet-adapter so deployments are
reproducible: replace tag: latest with a specific version tag or digest that
aligns with the ArgoCD targetRevision (e.g., the v0.3.0 image tag or
image@sha256:...), and change pullPolicy from Always to a stability-oriented
policy such as IfNotPresent (ensure you update any values.yaml entry and the
template references that render registry, repository, tag, and pullPolicy so the
chart uses the new pinned tag/digest).
In `@argocd/config/regional-cluster/hyperfleet-api-chart/values.yaml`:
- Around line 39-41: The values currently set image.tag: latest
(registry/repository/tag) with pullPolicy: Always makes deployments
non-deterministic; change image.tag from "latest" to a fixed immutable
identifier (a semantic version like "v1.2.3" or an image digest "sha256:...")
and set pullPolicy to IfNotPresent (or keep Always only when using digests) so
restarts use the pinned image; after updating tag, verify the image exists and
is accessible in the configured registry/repository
(quay.io/redhat-services-prod/hyperfleet-tenant/hyperfleet) from the
cluster/namespace and update any deployment docs or CI/image promotion steps
that reference image.tag.
In `@argocd/config/regional-cluster/hyperfleet-sentinel-chart/values.yaml`:
- Around line 43-45: The image for hyperfleet-sentinel is using tag: latest
which makes deployments unreproducible; update the values for registry:
quay.io/redhat-services-prod/hyperfleet-tenant/hyperfleet, repository:
hyperfleet-sentinel and replace tag: latest with a pinned, immutable tag (a
specific digest or version string) and ensure pullPolicy is adjusted
appropriately (e.g., IfNotPresent) so rollbacks/auditing are deterministic;
locate the image settings where tag: latest is declared for hyperfleet-sentinel
and substitute the concrete tag/digest and update pullPolicy to match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 58227b4e-d83f-4a5b-b68f-42fa86e68565
📒 Files selected for processing (4)
argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yamlargocd/config/regional-cluster/hyperfleet-adapter1-chart/values.yamlargocd/config/regional-cluster/hyperfleet-api-chart/values.yamlargocd/config/regional-cluster/hyperfleet-sentinel-chart/values.yaml
The hyperfleet-adapter v0.3.0 chart introduced a breaking change that requires broker.rabbitmq.queue when broker.type is rabbitmq. Without this field, ArgoCD's Helm template generation fails with: Error: execution error at (hyperfleet-adapter/templates/configmap-broker.yaml:8:4): broker.rabbitmq.queue is required when broker type is rabbitmq This prevented the hyperfleet-adapter1 deployment from being created, causing cluster readiness checks to timeout waiting for adapter1 to report as Available. The queue name "clusters" matches the topic configured in adapter-config.yaml. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yaml (1)
18-21:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPin the hyperfleet-adapter image tag to avoid deployment drift.
The image configuration still uses
tag: latestwithpullPolicy: Always, which prevents reproducible deployments and makes rollbacks/auditing difficult. A previous review already raised this concern.Pin the tag to a specific version or digest aligned with the
v0.3.0chart revision, and consider changingpullPolicytoIfNotPresentfor stability.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yaml` around lines 18 - 21, Update the image spec to stop using tag: latest and pullPolicy: Always—replace tag with a specific version or image digest matching the chart revision v0.3.0 (e.g., the hyperfleet-adapter image tag or SHA digest) and set pullPolicy to IfNotPresent for stability; modify the registry/repository/tag/pullPolicy fields in the hyperfleet-adapter image block so deployments are reproducible and auditable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In
`@argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yaml`:
- Around line 18-21: Update the image spec to stop using tag: latest and
pullPolicy: Always—replace tag with a specific version or image digest matching
the chart revision v0.3.0 (e.g., the hyperfleet-adapter image tag or SHA digest)
and set pullPolicy to IfNotPresent for stability; modify the
registry/repository/tag/pullPolicy fields in the hyperfleet-adapter image block
so deployments are reproducible and auditable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 24941748-90b8-4e1e-98df-f1804f15227f
📒 Files selected for processing (1)
argocd/config/regional-cluster/hyperfleet-adapter1-chart/templates/application.yaml
Collaborator
|
/test on-demand-e2e |
… override - Add exchange and routingKey to RabbitMQ broker config - Comment out adapter.version to use chart default Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
/test on-demand-e2e |
The enabled: false flag was preventing RabbitMQ broker setup. Commenting it out allows the default behavior from the chart. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
/test on-demand-e2e |
Configure sentinel to publish to the hyperfleet exchange with clusters routing key, matching the adapter's consumer configuration. Without these fields, sentinel publishes to the default exchange and events never reach the adapter. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changes exchange from "hyperfleet" to "clusters" and routingKey from "clusters" to "#" (wildcard) for broader message matching. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
openshift-ci
Bot
added
the
needs-rebase
Updates the reportClusterStatus action to use PUT method for updating cluster status, aligning with REST conventions for resource updates. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
openshift-ci
Bot
removed
the
needs-rebase
Collaborator
|
/test on-demand-e2e |
|
@typeid: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores