Remove VPC delete retry loop from e2e tests

[jmelis]

Summary

• Simplify the vpc-delete e2e spec from a 3-attempt retry loop with 5-minute backoff to a single rosactl cluster-vpc delete call
• Depends on Pre-clean orphaned ENIs and SGs before VPC stack delete rosa-hyperfleet-cli#85 which pre-cleans orphaned ENIs and security groups before stack deletion

The retry loop was needed because CloudFormation delete-stack would fail on the first attempt due to orphaned resources. With the CLI fix, the first attempt succeeds, so the retry is no longer needed. This saves ~15-20 minutes per CI run.

Test plan

• Merge Pre-clean orphaned ENIs and SGs before VPC stack delete rosa-hyperfleet-cli#85 first
• Verify go build ./test/e2e-cli/... passes
• CI: vpc-delete spec should pass without retries

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Simplified end-to-end cleanup verification for cluster VPC deletion.
  • The cleanup step now runs once and reports success or failure directly, making test behavior clearer and more predictable.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jmelis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9275c1cc-0062-45cc-a802-30e1de5ae6d4

📥 Commits

Reviewing files that changed from the base of the PR and between fb6b7b3 and c8fb992.

📒 Files selected for processing (1)

• test/e2e-cli/cluster_test.go

---

Walkthrough

The vpc-delete cleanup spec in cluster_test.go is simplified: the previous logic that listed the VPC, checked existence, and retried deletion up to three times with 5-minute backoffs is replaced with a single rosactl cluster-vpc delete invocation that fails immediately on error.

VPC Delete Cleanup Simplification

Layer / File(s)	Summary
Simplified vpc-delete spec test/e2e-cli/cluster_test.go	Replaces the list/verify/retry-with-backoff loop with a single cluster-vpc delete call that fails immediately on error and logs success on completion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ai-Attribution	⚠️ Warning	AI use is acknowledged, but the commit uses Co-Authored-By: Claude Opus 4.6 and has no Assisted-by/Generated-by trailer.	Replace the AI co-author line with a Red Hat-style Assisted-by: or Generated-by: trailer (and keep human authorship if needed).

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing the VPC delete retry loop from the e2e test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto	✅ Passed	The PR only changes the vpc-delete cleanup flow; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges	✅ Passed	No changed container/K8s manifest contains privileged settings; Dockerfile uses USER nonroot, and the only privileged hits are OpenAPI schema fields.
No-Sensitive-Data-In-Logs	✅ Passed	The new vpc-delete logs only clusterName and generic command output on failure; no passwords, tokens, PII, or hostnames are logged.
No-Hardcoded-Secrets	✅ Passed	No hardcoded secrets found in the changed vpc-delete cleanup code; it only uses env vars and command args.
No-Injection-Vectors	✅ Passed	The changed vpc-delete block uses exec.Command with fixed args; no sql/shell/eval/yaml/pickle/dangerous-innerHTML patterns appear in the modified code.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.