[ci-analyser-agent] fix: add --timeout=2h to test-e2e-cli ginkgo suite#103
Conversation
The nightly-integration job fails because the Ginkgo v2 default 1-hour suite timeout fires before test-e2e-cli completes. The test sequence spends ~40 minutes on HCP readiness and bundle waits, leaving only ~12 minutes when vpc-delete starts. The CloudFormation waiter in rosactl's DeleteVPC is configured for 15 minutes; Ginkgo fires first, and the cmd.CombinedOutput() call at cluster_test.go:802 blocks in pidfdWait and cannot be interrupted. Raise the suite timeout to 2 hours to give the full test sequence room to complete. Job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-online-rosa-regional-platform-main-nightly-integration
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rosa-regional-platform-ci The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 1 hour. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift-online/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @rosa-regional-platform-ci. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I'm not sure if this is the best course of action here. I'm going to defer to @ravitri. I'm going to unblock the testing and run an on-demand, but I'm not sure if the team wants to go in a different direction with this issue or not. /ok-to-test |
Root cause
The
nightly-integrationjob fails because Ginkgo v2's default 1-hour suite timeout fires beforetest-e2e-clifinishes.Timeline (from latest failed run)
With only ~12 minutes remaining when
vpc-deletestarts, the Ginkgo suite timeout fires before CloudFormation finishes. Thecmd.CombinedOutput()call atcluster_test.go:802blocks inpidfdWaitand cannot be interrupted by a Go context, so the suite hangs until the Prow job hard-kills it.Fix
Add
--timeout=2hto theginkgoinvocation intest-e2e-cli. The full test sequence takes roughly 50–55 minutes end-to-end; 2 hours gives comfortable headroom without masking genuine hangs.Failing job
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-online-rosa-regional-platform-main-nightly-integration
Changes
Makefile:test-e2e-cli— add--timeout=2hto theginkgoinvocation🤖 Opened automatically by the CI Analyser agent