Skip to content

[ci-analyser-agent] fix: add --timeout=2h to test-e2e-cli ginkgo suite#103

Closed
rosa-regional-platform-ci wants to merge 1 commit into
openshift-online:mainfrom
rosa-regional-platform-ci:fix/ci-nightly-integration-2026-06-15
Closed

[ci-analyser-agent] fix: add --timeout=2h to test-e2e-cli ginkgo suite#103
rosa-regional-platform-ci wants to merge 1 commit into
openshift-online:mainfrom
rosa-regional-platform-ci:fix/ci-nightly-integration-2026-06-15

Conversation

@rosa-regional-platform-ci

Copy link
Copy Markdown

Root cause

The nightly-integration job fails because Ginkgo v2's default 1-hour suite timeout fires before test-e2e-cli finishes.

Timeline (from latest failed run)

Step Duration Cumulative
HCP cluster ready ~34 min ~34 min
operator bundle wait ~6 min ~40 min
OIDC stack delete ~30 sec ~41 min
vpc-delete starts ~48 min used
CloudFormation waiter (rosactl) up to 15 min exceeds 60 min

With only ~12 minutes remaining when vpc-delete starts, the Ginkgo suite timeout fires before CloudFormation finishes. The cmd.CombinedOutput() call at cluster_test.go:802 blocks in pidfdWait and cannot be interrupted by a Go context, so the suite hangs until the Prow job hard-kills it.

Fix

Add --timeout=2h to the ginkgo invocation in test-e2e-cli. The full test sequence takes roughly 50–55 minutes end-to-end; 2 hours gives comfortable headroom without masking genuine hangs.

Failing job

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-online-rosa-regional-platform-main-nightly-integration

Changes

  • Makefile: test-e2e-cli — add --timeout=2h to the ginkgo invocation

🤖 Opened automatically by the CI Analyser agent

The nightly-integration job fails because the Ginkgo v2 default 1-hour
suite timeout fires before test-e2e-cli completes. The test sequence
spends ~40 minutes on HCP readiness and bundle waits, leaving only ~12
minutes when vpc-delete starts. The CloudFormation waiter in rosactl's
DeleteVPC is configured for 15 minutes; Ginkgo fires first, and the
cmd.CombinedOutput() call at cluster_test.go:802 blocks in pidfdWait and
cannot be interrupted.

Raise the suite timeout to 2 hours to give the full test sequence room
to complete.

Job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-online-rosa-regional-platform-main-nightly-integration
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rosa-regional-platform-ci
Once this PR has been reviewed and has the lgtm label, please assign psav for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rosa-regional-platform-ci, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bbb3449e-bdb0-4eac-84e9-69c70456d2bc

📥 Commits

Reviewing files that changed from the base of the PR and between 5d817c7 and 1d53720.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hi @rosa-regional-platform-ci. Thanks for your PR.

I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2026
@iamkirkbater

Copy link
Copy Markdown
Contributor

I'm not sure if this is the best course of action here. I'm going to defer to @ravitri. I'm going to unblock the testing and run an on-demand, but I'm not sure if the team wants to go in a different direction with this issue or not.

/ok-to-test
/test on-demand-e2e

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2026
@typeid typeid closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants