Red Hat Konflux kflux-prd-rh02 update kartograph-agent-runtime#776
Red Hat Konflux kflux-prd-rh02 update kartograph-agent-runtime#776red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <konflux@no-reply.konflux-ci.dev>
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo new Tekton Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.tekton/kartograph-agent-runtime-pull-request.yaml (1)
11-13: 🧹 Nitpick | 🔵 Trivial | 💤 Low valueCEL path filter includes redundant Dockerfile check.
The glob
"src/agent-runtime/***".pathChanged()already coverssrc/agent-runtime/Dockerfile. The explicit Dockerfile check is redundant but harmless.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.tekton/kartograph-agent-runtime-pull-request.yaml around lines 11 - 13, Remove the redundant explicit Dockerfile path check from the CEL expression in the pipelinesascode.tekton.dev/on-cel-expression field. The glob pattern "src/agent-runtime/***".pathChanged() already covers all files under src/agent-runtime/ including the Dockerfile, so delete the duplicate condition "src/agent-runtime/Dockerfile".pathChanged() while keeping the glob pattern and branch check intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/kartograph-agent-runtime-pull-request.yaml:
- Around line 520-531: The netrc workspace is declared in
pipelineSpec.workspaces (line 523-524) and used by the prefetch-dependencies
task, but it is not bound in the spec.workspaces section (lines 527-530). Add a
workspace binding for netrc in spec.workspaces using the same secret pattern as
the git-auth binding, ensuring it references the appropriate secret name that
contains the netrc configuration needed for private registry authentication
during the prefetch phase.
---
Nitpick comments:
In @.tekton/kartograph-agent-runtime-pull-request.yaml:
- Around line 11-13: Remove the redundant explicit Dockerfile path check from
the CEL expression in the pipelinesascode.tekton.dev/on-cel-expression field.
The glob pattern "src/agent-runtime/***".pathChanged() already covers all files
under src/agent-runtime/ including the Dockerfile, so delete the duplicate
condition "src/agent-runtime/Dockerfile".pathChanged() while keeping the glob
pattern and branch check intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 800a4b82-b9bc-451e-b67e-73589742938c
📒 Files selected for processing (2)
.tekton/kartograph-agent-runtime-pull-request.yaml.tekton/kartograph-agent-runtime-push.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual)openshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual)openshift-hyperfleet/hyperfleet-broker(manual)
| workspaces: | ||
| - name: git-auth | ||
| optional: true | ||
| - name: netrc | ||
| optional: true | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-kartograph-agent-runtime | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
There was a problem hiding this comment.
netrc workspace declared but not bound in spec.workspaces.
The prefetch-dependencies task maps workspace netrc (line 192-193), and pipelineSpec.workspaces declares it optional (line 523-524), but spec.workspaces (lines 527-530) only binds git-auth. If the agent-runtime requires private registry access during prefetch, this will silently fail to authenticate.
Proposed fix if netrc is needed
workspaces:
- name: git-auth
secret:
secretName: '{{ git_auth_secret }}'
+ - name: netrc
+ secret:
+ secretName: '{{ netrc_secret }}'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/kartograph-agent-runtime-pull-request.yaml around lines 520 - 531,
The netrc workspace is declared in pipelineSpec.workspaces (line 523-524) and
used by the prefetch-dependencies task, but it is not bound in the
spec.workspaces section (lines 527-530). Add a workspace binding for netrc in
spec.workspaces using the same secret pattern as the git-auth binding, ensuring
it references the appropriate secret name that contains the netrc configuration
needed for private registry authentication during the prefetch phase.
|
Closing as superseded by #737, which merged the Konflux pipeline configuration for No need to merge this Konflux bootstrap PR — the |
1 participant
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization
Please follow the block sequence indentation style introduced by the proprosed PipelineRuns YAMLs, or keep using consistent indentation level through your customized PipelineRuns. When different levels are mixed, it will be changed to the proposed style.