Skip to content

HYPERFLEET-1278 - remove email restriction for audit fields#205

Open
rh-amarin wants to merge 1 commit into
openshift-hyperfleet:mainfrom
rh-amarin:HYPERFLEET-1278
Open

HYPERFLEET-1278 - remove email restriction for audit fields#205
rh-amarin wants to merge 1 commit into
openshift-hyperfleet:mainfrom
rh-amarin:HYPERFLEET-1278

Conversation

@rh-amarin

Copy link
Copy Markdown
Contributor

Summary

Update to API contract v1.0.25

@openshift-ci openshift-ci Bot requested review from kuudori and ldornele June 29, 2026 14:34
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1e46317d-2f3a-4c98-8a86-a3fdae610a0e

📥 Commits

Reviewing files that changed from the base of the PR and between 3ffc587 and 8f2b0d4.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum, !**/go.sum
📒 Files selected for processing (1)
  • go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated a core API dependency to the latest patch version, helping keep the app aligned with recent upstream changes and compatibility improvements.

Walkthrough

go.mod bumps the direct dependency github.com/openshift-hyperfleet/hyperfleet-api-spec from v1.0.24 to v1.0.25. No other files are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Supply chain surface — CWE-1104 (Use of Unmaintained Third-Party Components) / CWE-829 (Inclusion of Functionality from Untrusted Control Sphere).

Verify before merging:

  • go.sum entry for v1.0.25 matches the upstream checksum (go mod verify).
  • v1.0.25 tag on github.com/openshift-hyperfleet/hyperfleet-api-spec points to an expected, reviewed commit — not a tag move or force-push.
  • No new exported types or removed types in v1.0.25 that silently change Sentinel's API contract at compile time without a corresponding code review here.
  • go.sum file is included in this PR; if it is not, the bump is incomplete and the build is non-deterministic.
🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the tracked issue and aligns with the API contract bump to v1.0.25.
Description check ✅ Passed The description directly describes the API contract update reflected in go.mod.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PASS: No non-test log/print statements contain token/password/credential/secret; only JSON keys in test/mock-hyperfleet-api, not logs. CWE-532.
No Hardcoded Secrets ✅ Passed Diff only bumps a Go module and updates go.sum checksums; no hardcoded credentials (CWE-798) or URL creds found.
No Weak Cryptography ✅ Passed PASS: Only go.mod was bumped to hyperfleet-api-spec v1.0.25; no banned primitives (crypto/md5, des, rc4, SHA1 for security, ECB) or secret comparisons changed. CWE-327.
No Injection Vectors ✅ Passed PASS: PR only bumps hyperfleet-api-spec in go.mod/go.sum; no changed code adds CWE-89/CWE-78/CWE-79/CWE-502 sinks.
No Privileged Containers ✅ Passed Only go.mod changed; no manifests/Dockerfiles touched, so no privileged-container issue (CWE-284/CWE-269).
No Pii Or Sensitive Data In Logs ✅ Passed Only go.mod/go.sum changed for a dependency bump; no log statements or PII sinks were modified, so no CWE-532 exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@kuudori

kuudori commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 6 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

@rh-amarin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-commits 8f2b0d4 link true /test validate-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants