HYPERFLEET-1108 - feat: Add run id labels to the adapter configs for …#62
HYPERFLEET-1108 - feat: Add run id labels to the adapter configs for …#62ma-hill wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
Adds run ID labels to E2E adapter configurations to enable cleanup of test resources created during specific test runs. When running E2E tests, resources (deployments, jobs, namespaces, configmaps, manifestworks) are created across multiple clusters and can accumulate if tests fail or are interrupted. This change propagates a
RUN_IDenvironment variable through adapter task configs and into resource labels, allowing test cleanup scripts to query and delete all resources associated with a specific test run using label selectors.HYPERFLEET-1108
Changes
runIdparameter to all E2E adapter task configs (cl-deployment,cl-job,cl-maestro,cl-namespace,np-configmap) sourced fromenv.RUN_IDe2e.hyperfleet.io/run-idlabels to all adapter-created resources:RUN_IDenvironment variable to base adapter configuration inhelmfile/values/base-adapter.yaml.gotmplwith default value"unknown"{{ if .runId }}to maintain backward compatibility whenRUN_IDis not setNotes
The
runIdparameter is optional (required: false) to maintain backward compatibility with existing test setups that don't setRUN_ID. Resources created without a run ID will have the label omitted entirely rather than set to a default value, making it easier to distinguish between labeled and unlabeled resources during cleanup.Change associated
Test Plan