Skip to content

Fix memory leak: ExecutionEngine recreated per query appending to global function registry #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penghuo merged 2 commits into from
Mar 16, 2026
+4 −7
Merged

Fix memory leak: ExecutionEngine recreated per query appending to global function registry #5222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a77e23b
Fix memory leak: ExecutionEngine recreated per query appending to glo…
ahkcs Mar 10, 2026
1d661ac
Apply spotless formatting
ahkcs Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions core/src/main/java/org/opensearch/sql/expression/function/PPLFuncImpTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,10 @@ public void registerExternalOperator(BuiltinFunctionName functionName, SqlOperat
functionName.name(),
operator instanceof SqlUserDefinedFunction);
CalciteFuncSignature signature = new CalciteFuncSignature(functionName.getName(), typeChecker);
externalFunctionRegistry.compute(
externalFunctionRegistry.put(
functionName,
(name, existingList) -> {
List<Pair<CalciteFuncSignature, FunctionImp>> list =
existingList == null ? new ArrayList<>() : new ArrayList<>(existingList);
list.add(Pair.of(signature, (builder, args) -> builder.makeCall(operator, args)));
return list;
});
List.of(
Pair.of(signature, (FunctionImp) (builder, args) -> builder.makeCall(operator, args))));
}

/**
Expand Down
1 change: 1 addition & 0 deletions plugin/src/main/java/org/opensearch/sql/plugin/config/OpenSearchPluginModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public StorageEngine storageEngine(OpenSearchClient client, Settings settings) {
}

@Provides
@Singleton
public ExecutionEngine executionEngine(
OpenSearchClient client, ExecutionProtector protector, PlanSerializer planSerializer) {
return new OpenSearchExecutionEngine(client, protector, planSerializer);
Expand Down
Loading