Skip to content

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (security) - #6461

Merged
DarshitChanpura merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:ci/spotless-jdt-pin
Sep 3, 2026
Merged

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (security)#6461
DarshitChanpura merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:ci/spotless-jdt-pin

Conversation

@peterzhuamazon

@peterzhuamazon peterzhuamazon commented Sep 3, 2026

Copy link
Copy Markdown
Member

Description

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version. The guard and mirror already landed in #6438; this PR adds the version pin.

Issues Resolved

opensearch-project/opensearch-build#6421

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n (security)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit ddd9fec.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
build.gradle61highBuild plugin version change: 'com.diffplug.spotless' upgraded from 6.25.0 to 8.10.1 — a major version bump (v6→v8). Per mandatory supply chain policy, all build plugin version changes must be flagged for maintainer verification. Artifact authenticity cannot be confirmed without checking the Gradle plugin portal.
gradle/formatting.gradle25highEclipse formatter artifact version explicitly pinned to '4.29', changing what artifact is resolved at build time. This is a build-time dependency change (fetched via P2 mirror) and must be verified by maintainers to confirm the artifact resolves to the expected Eclipse release and has not been tampered with.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 2 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@peterzhuamazon peterzhuamazon changed the title Pin the Eclipse JDT formatter version for spotless lockfile resolution (security) Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (security) Sep 3, 2026
@peterzhuamazon peterzhuamazon added enhancement New feature or request release Project release v3.9.0 Version 3.9.0 skip-changelog backport 2.19 backport to 2.19 branch backport 3.8 Backports to 3.8 labels Sep 3, 2026
@peterzhuamazon peterzhuamazon moved this from Backlog to In review in OpenSearch Engineering Effectiveness Sep 3, 2026
@peterzhuamazon

Copy link
Copy Markdown
Member Author

expected version pin

@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.75%. Comparing base (c33b831) to head (ddd9fec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6461      +/-   ##
==========================================
- Coverage   75.75%   75.75%   -0.01%     
==========================================
  Files         457      457              
  Lines       30508    30508              
  Branches     4615     4615              
==========================================
- Hits        23111    23110       -1     
- Misses       5276     5278       +2     
+ Partials     2121     2120       -1     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura
DarshitChanpura merged commit e81ceeb into opensearch-project:main Sep 3, 2026
89 of 91 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19 backport to 2.19 branch backport 3.8 Backports to 3.8 enhancement New feature or request release Project release skip-changelog skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. v3.9.0 Version 3.9.0

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants