-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add Gradle-level verification of dependency SHAs #22859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msfroh
wants to merge
7
commits into
opensearch-project:main
Choose a base branch
from
msfroh:gradle_sha_verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
008cc53
Add Gradle-level verification of dependency SHAs
msfroh f9638a8
Update to latest dependencies
msfroh 680a462
Add artifacts needed for :server:japicmp target
msfroh b12e5bb
Add new Adoptium artifacts
msfroh 3cb37ef
Add some more dependencies for :server:japicmp
msfroh 7c6d484
Add more :server:japicmp dependencies
msfroh 02e0157
Add SHAs for sandbox sub-projects
msfroh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
sandbox/libs/analytics-framework/licenses/jackson-core-2.22.1.jar.sha1
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
sandbox/libs/analytics-framework/licenses/jackson-core-2.22.2.jar.sha1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 13a748ea3e329fa220076e021b45c8391b32420c |
1 change: 0 additions & 1 deletion
1
sandbox/libs/analytics-framework/licenses/jackson-databind-2.22.1.jar.sha1
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
sandbox/libs/analytics-framework/licenses/jackson-databind-2.22.2.jar.sha1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 921bd2092b0c539b2876de7063d55c72edcd05d3 |
1 change: 0 additions & 1 deletion
1
sandbox/plugins/analytics-backend-datafusion/licenses/jackson-datatype-jdk8-2.22.1.jar.sha1
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
sandbox/plugins/analytics-backend-datafusion/licenses/jackson-datatype-jdk8-2.22.2.jar.sha1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 0b900dd7125fa16cfdf46135d3ffb3243d0f8b88 |
1 change: 0 additions & 1 deletion
1
sandbox/plugins/analytics-engine/licenses/jackson-dataformat-yaml-2.22.1.jar.sha1
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
sandbox/plugins/analytics-engine/licenses/jackson-dataformat-yaml-2.22.2.jar.sha1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| a4f075bf4cc1ee814ab98d69c1612786c2f42bc3 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This two-step process to update dependencies can save a lot of time, since the default "online" mode for
--write-verification-metadataseems to read from the various artifactories for every single task (as I understand it).The
:qa:ossubprojects iterate through every listed OS and every version of OpenSearch defined inVersion.javaand fetches Jackson + JUnit dependencies. On my laptop, the online mode takes over 6 minutes (though I've seen it go as high as 9 minutes), while the offline mode is closer to 1 minute.Removing the
:qa:ossubprojects and removing most of the unused constants inVersion.javacuts the online metadata regeneration time to 1m30s, which is much closer to our oldupdateSHAstask.The two-step process exists as a workaround until then, but it didn't work for me with
-Dsandbox-enabled=true, because it insisted thatarrow-compression-18.1.0.jarwas not cached for offline verification (though I could clearly see it in my Gradle cache).So, to summarize:
./gradlew --write-verification-metadata sha256 precommit -Denable.sandbox=true. Go grab a coffee.:qa:ostasks and remove some cruft fromVersion.java, then this whole section can be a lot shorter and just document the online regeneration step (since it will be decently fast).