[Analytics Engine] CSE: evaluate a repeated aggregate sub-plan once instead of twice - #22818
[Analytics Engine] CSE: evaluate a repeated aggregate sub-plan once instead of twice#22818LantaoJin wants to merge 5 commits into
Conversation
PR Reviewer Guide 🔍(Review updated until commit 64c6cf5)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 64c6cf5 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 4872a29
Suggestions up to commit 5acca8e
Suggestions up to commit f5f7a5b
Suggestions up to commit 87bd880
Suggestions up to commit 9046c78
|
Signed-off-by: Lantao Jin <ltjin@amazon.com>
9046c78 to
87bd880
Compare
|
Persistent review updated to latest commit 87bd880 |
|
❌ Gradle check result for 87bd880: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22818 +/- ##
============================================
+ Coverage 71.58% 71.59% +0.01%
+ Complexity 77341 77323 -18
============================================
Files 6170 6170
Lines 359775 359774 -1
Branches 52478 52478
============================================
+ Hits 257541 257577 +36
+ Misses 81770 81714 -56
- Partials 20464 20483 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Persistent review updated to latest commit f5f7a5b |
|
Persistent review updated to latest commit 5acca8e |
|
❌ Gradle check result for 5acca8e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 4872a29 |
|
Persistent review updated to latest commit 64c6cf5 |
Description
Support CSE (common subexpression elimination) optimization to resolve correctness issue introduced by nondeterministic aggregation in subquery.
New configuration:
analytics.planner.subplan_reuse.enabled (default: true)
Related Issues
Resolves #22817
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.