Skip to content

Register status_counter as filterable index metric in node stats API #22388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gingeekrishna wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Register status_counter as filterable index metric in node stats API #22388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52b968a
Register status_counter as a filterable index metric in node stats API
Jul 5, 2026
58b6df7
Merge branch 'main' into fix/22383-status-counter-metric-filtering
gingeekrishna Aug 16, 2026
14b0dcd
Merge branch 'main' into fix/22383-status-counter-metric-filtering
gingeekrishna Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/src/main/java/org/opensearch/action/admin/indices/stats/CommonStatsFlags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ public enum Flag {
Translog("translog", 13),
// 14 was previously used for Suggest
RequestCache("request_cache", 15),
Recovery("recovery", 16);
Recovery("recovery", 16),
StatusCounter("status_counter", 17);

private final String restName;
private final int index;
Expand Down
11 changes: 9 additions & 2 deletions server/src/main/java/org/opensearch/indices/IndicesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,11 +927,18 @@ public NodeIndicesStats stats(CommonStatsFlags flags) {
break;
}
}
// Only include status_counter when it is explicitly requested (or when all flags are set).
// Previously it was always included regardless of the requested index metrics, causing it
// to appear even for targeted requests like GET _nodes/stats/indices/request_cache.
// See https://github.com/opensearch-project/OpenSearch/issues/22383
final StatusCounterStats resolvedStatusCounterStats = flags.isSet(CommonStatsFlags.Flag.StatusCounter)
? statusCounterStats
: null;
if (flags.getIncludeIndicesStatsByLevel()) {
NodeIndicesStats.StatsLevel statsLevel = NodeIndicesStats.getAcceptedLevel(flags.getLevels());
return new NodeIndicesStats(commonStats, statsByShard(this, flags), searchRequestStats, statusCounterStats, statsLevel);
return new NodeIndicesStats(commonStats, statsByShard(this, flags), searchRequestStats, resolvedStatusCounterStats, statsLevel);
} else {
return new NodeIndicesStats(commonStats, statsByShard(this, flags), searchRequestStats, statusCounterStats);
return new NodeIndicesStats(commonStats, statsByShard(this, flags), searchRequestStats, resolvedStatusCounterStats);
}
}

Expand Down
Loading