fix: actually test on python different versions in CI 🤦#368
Merged
bloodearnest merged 1 commit intomainfrom Oct 10, 2025
Merged
fix: actually test on python different versions in CI 🤦#368bloodearnest merged 1 commit intomainfrom
bloodearnest merged 1 commit intomainfrom
Conversation
bloodearnest
force-pushed
the
fix-ci-again
branch
2 times, most recently
from
34def1a to
9256fae
Compare
bloodearnest
force-pushed
the
fix-ci-again
branch
from
9256fae to
6fa2994
Compare
bloodearnest
changed the title
bloodearnest
changed the title
evansd
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, this was attempting to fix breakage introduced by moving to
just buildin the publishing workflow, but fixing that uncovered that we a) were defaulting to 3.10 in dev rather than our minimum version, 3.8 and b) we were actually always testing on 3.10 on linux in CI, not the matrix python version.This was an unintended side effect of this change: 4412a99
Moving from running
python -m pytesttojust testmeant that we needed to specify PYTHON_VERSION env var to specify the version of python we are using, as we are using the just file's virtualenv machinery.This is a
fix:tagged release, rather thanchore:, because it also (hopefully) fixes the release machinery which was broken for similar moving from direct python to just.