Assert the resolved Stubborn Contract Maven plugin version - #101
Merged
Conversation
`stubborn-contract-migration` 0.1.2 repins every migrated coordinate to `latest.release`, so the plugin version no longer stays at the Spring Cloud Contract version the pom started with. Assert on the shape of the resolved version instead of pinning it, so releases of the plugin don't break the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly build broke on
MigrateFromSpringCloudContractTest.migrateMavenPlugin: the test expected the migratedsh.stubborn:stubborn-contract-maven-pluginto keep the4.1.4version the Spring Cloud Contract plugin had, but got0.1.2.Upstream
sh.stubborn:stubborn-contract-migration0.1.2 (published today, and picked up here vialatest.release) mergedUpdateMavenDependencies/UpdateGradleDependenciesinto a singleUpdateDependenciesrecipe and addednewVersion: latest.releaseto every coordinate change, including the Maven plugin.Rather than pin the expectation to whatever the current Stubborn Contract release is, assert the plugin coordinates were swapped and a version was resolved, and hand the actual back as the expected output.
Verified locally: with Maven Central reachable the assertion passes; the only local failure left is a
HTTP 429from Central against my IP, which also blocked resolution in the test JVM.