Skip to content

fix: comments must not break rewritten assertions #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cortlepp wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: comments must not break rewritten assertions #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/test/java/org/openrewrite/java/testing/junit5/AssertToAssertionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,40 @@ public void test() {
);
}

@Test
void commentWithMessage() {
//language=java
rewriteRun(
java(
"""
import org.junit.Test;
import static org.junit.Assert.assertTrue;

public class MyTest {
@Test
public void test() {
assertTrue("a message", true//a weird comment
);
}
}
""",
"""
import org.junit.Test;

import static org.junit.jupiter.api.Assertions.assertTrue;

public class MyTest {
@Test
public void test() {
assertTrue(true, "a message"//a weird comment
);
}
}
"""
)
);
}

@Test
void assertWithoutMessage() {
//language=java
Expand Down
Loading