Inline precondition-wrapped nested visitor classes - #1028
Merged
Conversation
Declare the visitors anonymously inside the `Preconditions.check(..)` call rather than as named nested classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Inline nested visitor classes into
getVisitor()#1026 and InlineUseStringReplaceVisitorintogetVisitor()#1027, which inlined the nested visitors returned directly fromgetVisitor(). This does the same for five visitors that are wrapped inPreconditions.check(..), declaring them anonymously in place and hoisting theirprivate static finalconstants onto the recipe class.The
InlineNestedVisitorClassrecipe deliberately does not handle the precondition-wrapped shape yet — inlining a large visitor underPreconditions.check(..)can hurt readability — so this phases the pattern out here with a small scope (all five visitors are under 55 lines) while leaving it in place elsewhere for now.RemoveInstanceOfPatternMatchis intentionally untouched: its visitor is 174 lines and carries Javadoc that inlining would drop.Beyond the class declarations and the hoisted constants the diff is a pure re-indent;
./gradlew buildpasses.