RemoveRedundantTypeCast: keep casts on signature-polymorphic methods - #1025
Merged
Conversation
MethodHandle#invoke/invokeExact and the VarHandle accessors are signature-polymorphic (JLS 15.12.3): the enclosing cast is what gives the call site its return type, so removing it reverts the call to Object and breaks compilation. Fixes #1024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodHandle#invoke/invokeExactand theVarHandleaccessors are signature-polymorphic (JLS 15.12.3): the call site has no fixed signature, and the enclosing cast is what supplies the return type. The recipe compared the attributed expression type against the cast type, but that attributed type only exists because of the cast, so the check always succeeded and the cast was always removed — leaving code that no longer compiles:Now a cast whose expression is a method invocation declared on
java.lang.invoke.MethodHandleorjava.lang.invoke.VarHandleis preserved.