Add jakarta.validation-api dependency when migrating com.sun.istack.NotNull - #1190
Merged
steve-aom-elliott merged 3 commits intoAug 11, 2026
Merged
Conversation
…otNull The JavaxValidationMigrationToJakartaValidation aggregator rewrites com.sun.istack.NotNull to jakarta.validation.constraints.NotNull, but only added the jakarta.validation-api dependency when the source already used javax.validation. Sources that used only com.sun.istack.NotNull got their imports swapped with no corresponding dependency added, producing an uncompilable result.
Contributor
Author
|
For context, I think
|
timtebeek
approved these changes
Aug 10, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
…n tests Replace source stubs with testParserClasspath entries for com.sun.istack:istack-commons-runtime and jakarta.validation:jakarta.validation-api, so the parser resolves the actual annotation types.
Fold the source-only sunIstackNotNullToJakartaValidation into a single test that covers both the import swap and the dependency addition, and assert the resulting pom in full rather than via a partial regex match.
steve-aom-elliott
marked this pull request as ready for review
August 11, 2026 16:32
steve-aom-elliott
deleted the
add-jakarta-validation-dep-for-sun-istack
branch
August 11, 2026 16:32
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Aug 20, 2026
…41.0 to 3.42.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.41.0 to 3.42.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.42.0 > ------ > > What's Changed > -------------- > > * Adopt upstream XML trailing-comment formatting by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1180](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1180) > * Add mapping for CheckForNull to JSpecify annotation by [`@zbynek`](https://github.com/zbynek) in [openrewrite/rewrite-migrate-java#1179](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1179) > * Skip `UseSetOf`/`UseListOf` for `HashSet`/`ArrayList` subclasses by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1182](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1182) > * Avoid hardcoded patch version in UpdateSdkManTest by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1183](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1183) > * Only add the Mockito surefire agent configuration when asked, and keep it minimal by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1184](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1184) > * Make subpackage recursion explicit in the Jackson JAX-RS JSON rename by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1185](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1185) > * Add the Mockito agent properties goal in its own execution by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-migrate-java#1186](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1186) > * Derive SDKMAN test versions from the candidate list by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1188](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1188) > * Do not apply `var` when the generic return type needs the declared type by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#1187](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1187) > * Cover legacy Bouncy Castle artifacts and their API changes by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1189](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1189) > * Add jakarta.validation-api dependency when migrating com.sun.istack.NotNull by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#1190](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1190) > > New Contributors > ---------------- > > * [`@zbynek`](https://github.com/zbynek) made their first contribution in [openrewrite/rewrite-migrate-java#1179](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1179) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.41.0...v3.42.0> Commits * [`1238ceb`](openrewrite/rewrite-migrate-java@1238ceb) OpenRewrite recipe best practices * [`01d0fe8`](openrewrite/rewrite-migrate-java@01d0fe8) Add `jakarta.validation-api` dependency when migrating `com.sun.istack.NotNul... * [`33354b5`](openrewrite/rewrite-migrate-java@33354b5) Cover legacy Bouncy Castle artifacts and their API changes ([#1189](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1189)) * [`6c648a5`](openrewrite/rewrite-migrate-java@6c648a5) Update Gradle wrapper to 9.7.0 * [`7099ad3`](openrewrite/rewrite-migrate-java@7099ad3) Do not apply `var` when the generic return type needs the declared type ([#1187](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1187)) * [`ccfa7b0`](openrewrite/rewrite-migrate-java@ccfa7b0) Derive SDKMAN test versions from the candidate list ([#1188](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1188)) * [`96e8647`](openrewrite/rewrite-migrate-java@96e8647) [Auto] SDKMAN! Java candidates as of 2026-08-10T1102 * [`26f898e`](openrewrite/rewrite-migrate-java@26f898e) Add the Mockito agent properties goal in its own execution ([#1186](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1186)) * [`d82dd47`](openrewrite/rewrite-migrate-java@d82dd47) OpenRewrite recipe best practices * [`55f2e93`](openrewrite/rewrite-migrate-java@55f2e93) Make subpackage recursion explicit in the Jackson JAX-RS JSON rename ([#1185](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1185)) * Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.41.0...v3.42.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JavaxValidationMigrationToJakartaValidationaggregator rewritescom.sun.istack.NotNulltojakarta.validation.constraints.NotNullviaChangeType, but the accompanyingAddDependencyforjakarta.validation:jakarta.validation-apiwas guarded byonlyIfUsing: javax.validation..*. Sources that used onlycom.sun.istack.NotNullhad their imports swapped with no corresponding dependency added, producing an uncompilable result.This adds a second
AddDependencyentry guarded byonlyIfUsing: com.sun.istack.NotNullso the dependency is added in that case as well. Test coverage extended to assert the POM change.