Skip to content

Derive SDKMAN test versions from the candidate list #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Aug 10, 2026
Merged

Derive SDKMAN test versions from the candidate list #1188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions src/test/java/org/openrewrite/java/migrate/UpdateSdkManTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,53 @@
import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.InMemoryExecutionContext;
import org.openrewrite.semver.LatestRelease;
import org.openrewrite.test.RewriteTest;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.util.regex.Pattern;

import static org.assertj.core.api.Assertions.assertThat;
import static org.openrewrite.test.SourceSpecs.text;


class UpdateSdkManTest implements RewriteTest {

/**
* The nightly SDKMAN! candidates refresh drops patch versions as new ones appear, so tests that need an exact
* version read a currently available one from the same candidate list the recipe resolves against.
*/
private static String latestPatchVersion(String majorVersion, String distribution) {
Pattern pattern = Pattern.compile("^" + majorVersion + "\\.\\d+\\.\\d+-" + distribution + "$");
try (InputStream candidates = UpdateSdkMan.class.getResourceAsStream("/sdkman-java.csv");
BufferedReader reader = new BufferedReader(new InputStreamReader(candidates, StandardCharsets.UTF_8))) {
return reader.lines()
.filter(candidate -> pattern.matcher(candidate).matches())
.max(new LatestRelease("-" + distribution))
.map(candidate -> candidate.substring(0, candidate.length() - distribution.length() - 1))
.orElseThrow(() -> new IllegalStateException(
String.format("No %s candidate for Java %s in sdkman-java.csv", distribution, majorVersion)));
} catch (IOException e) {
throw new UncheckedIOException(e);
}
}

@DocumentExample
@Test
void updateVersionExact() {
String version = latestPatchVersion("17", "tem");
rewriteRun(
spec -> spec.recipe(new UpdateSdkMan("17.0.19", null)),
spec -> spec.recipe(new UpdateSdkMan(version, null)),
text(
"""
java=11.1.2-tem
""",
"""
java=17.0.19-tem
""",
"java=" + version + "-tem\n",
spec -> spec.path(".sdkmanrc")
)
);
Expand All @@ -59,15 +86,12 @@ void updateVersionUsingMajorOnly() {

@Test
void updateDistributionOnly() {
String version = latestPatchVersion("11", "amzn");
rewriteRun(
spec -> spec.recipe(new UpdateSdkMan(null, "amzn")),
text(
"""
java=11.0.31-zulu
""",
"""
java=11.0.31-amzn
""",
"java=" + version + "-zulu\n",
"java=" + version + "-amzn\n",
spec -> spec.path(".sdkmanrc")
)
);
Expand Down
Loading