Skip to content

Add mapping for CheckForNull to JSpecify annotation #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 2 commits into from
Jul 31, 2026
Merged

Add mapping for CheckForNull to JSpecify annotation #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbcfe6c
Add mapping for CheckForNull to JSpecify annotation
zbynek Jul 30, 2026
196be9e
Merge branch 'main' into patch-1
timtebeek Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/resources/META-INF/rewrite/jspecify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ recipeList:
oldFullyQualifiedTypeName: javax.annotation.Nullable
newFullyQualifiedTypeName: org.jspecify.annotations.Nullable
ignoreDefinition: true
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: javax.annotation.CheckForNull
newFullyQualifiedTypeName: org.jspecify.annotations.Nullable
ignoreDefinition: true
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: javax.annotation.Nonnull
newFullyQualifiedTypeName: org.jspecify.annotations.NonNull
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/jspecify/JSpecifyBestPracticesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ void migrateFromJavaxAnnotationApiToJspecify() {
"""
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import javax.annotation.CheckForNull;

public class Test {
@Nonnull
Expand All @@ -54,6 +55,8 @@ public class Test {
public String field2;
@Nullable
public Foo.Bar foobar;
@CheckForNull
public String checked;
}

interface Foo {
Expand All @@ -73,6 +76,8 @@ public class Test {
@Nullable
public String field2;
public Foo.@Nullable Bar foobar;
@Nullable
public String checked;
}

interface Foo {
Expand Down
Loading