Skip to content

Move Java EE 8 servlet update into separate recipe - #1170

Merged
timtebeek merged 2 commits into
openrewrite:mainfrom
rlsanders4:java8
Jul 17, 2026
Merged

Move Java EE 8 servlet update into separate recipe#1170
timtebeek merged 2 commits into
openrewrite:mainfrom
rlsanders4:java8

Conversation

@rlsanders4

Copy link
Copy Markdown
Contributor

What's changed?

This PR moves the Java EE 8 Servlet update to 3.x into a separate recipe. This new recipe is then referenced by the org.openrewrite.java.migrate.javaee8 recipe list. Also, the order of the recipes in this list was adjusted to ensure that org.openrewrite.java.migrate.javaee7 recipe is called first.

What's your motivation?

Splitting this recipe out allows for users to call it individually, without invoking the full Java EE 8 recipe list. Moving the Java EE 7 recipes to the top of the Java EE 8 list ensures that updates are made in the correct order for users migrating across multiple Java EE levels.

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@rlsanders4 rlsanders4 self-assigned this Jul 16, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Jul 16, 2026
@rlsanders4
rlsanders4 requested a review from timtebeek July 16, 2026 19:15

@timtebeek timtebeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again! No idea why these were ever in a different order; this indeed makes more sense.

@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite Jul 17, 2026
@timtebeek
timtebeek merged commit a5b7ddc into openrewrite:main Jul 17, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Jul 17, 2026
@rlsanders4
rlsanders4 deleted the java8 branch July 17, 2026 12:52
mergify Bot added a commit to robfrank/linklift that referenced this pull request Aug 4, 2026
…40.0 to 3.41.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.40.0 to 3.41.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).*

> 3.41.0
> ------
>
> What's Changed
> --------------
>
> * Add Mockito Java agent surefire config in reactor modules by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1169](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1169)
> * Move Java EE 8 servlet update into separate recipe by [`@​rlsanders4`](https://github.com/rlsanders4) in [openrewrite/rewrite-migrate-java#1170](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1170)
> * Update NoGuavaRefaster expected output for upstream static-import change by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1171](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1171)
> * Set Develocity `projectId` to "openrewrite" by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1172](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1172)
> * Add `mapstruct-processor` to annotation processor paths when Lombok and MapStruct are used by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1175](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1175)
> * Fix method patterns for dead `UnsignedInts`/`UnsignedLongs` recipes by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1176](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1176)
> * Migrate web.xml xsi:schemaLocation from J2EE 1.4 namespace by [`@​steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#1177](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1177)
> * Forward Code Genome Project publish credentials to `ci-gradle.yml` by [`@​jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-migrate-java#1178](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1178)
>
> **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.40.0...v3.41.0>


Commits

* [`128764a`](openrewrite/rewrite-migrate-java@128764a) Forward Code Genome Project publish credentials to `ci-gradle.yml` ([#1178](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1178))
* [`39b31e8`](openrewrite/rewrite-migrate-java@39b31e8) Migrate web.xml xsi:schemaLocation from J2EE 1.4 namespace ([#1177](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1177))
* [`e7f0b34`](openrewrite/rewrite-migrate-java@e7f0b34) [Auto] SDKMAN! Java candidates as of 2026-07-27T1252
* [`e29c330`](openrewrite/rewrite-migrate-java@e29c330) Fix method patterns for dead `UnsignedInts`/`UnsignedLongs` recipes ([#1176](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1176))
* [`7c45df7`](openrewrite/rewrite-migrate-java@7c45df7) Add `mapstruct-processor` to annotation processor paths when Lombok and MapSt...
* [`ab370a9`](openrewrite/rewrite-migrate-java@ab370a9) Set Develocity `projectId` to "openrewrite" ([#1172](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1172))
* [`cddded8`](openrewrite/rewrite-migrate-java@cddded8) Move Develocity to community.develocity.cloud
* [`577446f`](openrewrite/rewrite-migrate-java@577446f) Update NoGuavaRefaster expected output for upstream static-import change ([#1171](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1171))
* [`9b7a874`](openrewrite/rewrite-migrate-java@9b7a874) [Auto] SDKMAN! Java candidates as of 2026-07-20T1212
* [`a5b7ddc`](openrewrite/rewrite-migrate-java@a5b7ddc) Move Java EE 8 servlet update into separate recipe ([#1170](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1170))
* Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.40.0...v3.41.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants