Let TestKit fixtures resolve io.moderne from the Code Genome Project - #473
Merged
Conversation
The CGP repository #472 added to the TestKit fixtures is scoped to org[.]openrewrite.*, so io.moderne artifacts are only looked up on Maven Central. jsonrpc 1.0.13 is the first jsonrpc release published only to CGP, and rewrite-core 8.92.0-SNAPSHOT pins it via latest.release, which failed 39 of 58 TestKit tests on the scheduled run with 'Could not find io.moderne:jsonrpc:1.0.13'. Widen the content filter to both groups, matching what plugin/build.gradle.kts already does for the main build.
timtebeek
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / problem
The scheduled ci run #33002073829 failed 39 of 58 TestKit tests, all with
Could not find io.moderne:jsonrpc:1.0.13, required byorg.openrewrite:rewrite-core:8.92.0-SNAPSHOT:20260826.175419-1. Gradle only searched~/.m2and Maven Central for it.This plugin declares no
io.modernedependency of its own.jsonrpcis the onlyio.moderneartifact in the run and it arrives transitively:rewrite-coredeclaresimplementation("io.moderne:jsonrpc:latest.release")and ships it as aruntimedependency in its POM, because theorg.openrewrite.rpcpackage (RewriteRpc,RewriteRpcProcessand theParse,Print,Visit,Generaterequest types) uses it as the JSON-RPC transport to out-of-process language servers. Every consumer ofrewrite-corepulls it in whether or not it uses RPC, and the TestKit builds resolverewrite-corewhenrewriteDryRun,rewriteRunandrewriteDiscoverbuild their recipe classpath.Two things then lined up.
moderneinc/jsonrpccut 1.0.13 earlier today, its first release since it stopped publishing to Maven Central, so the artifact exists only on the Code Genome Project while Central stops at 1.0.12. Today'srewrite-coresnapshot therefore pins 1.0.13. Meanwhile #472 pointed the TestKit fixtures at CGP but scoped that repository withincludeGroupByRegex("org[.]openrewrite.*").io.modernefalls outside the filter, so the fixture builds never ask CGP for jsonrpc. The push run on the same commit was green only because the snapshot at that time still pinned 1.0.12.Solution
Widen the CGP content filter in
TestKitRepositoriesto(org[.]openrewrite|io[.]moderne).*, which is the same pair of groupsplugin/build.gradle.ktsalready routes to CGP for the main build. The fallback declarations for builds without credentials are unchanged.Test plan
:plugin:compileKotlinlocallyjsonrpc:1.0.13in the TestKit builds