Skip to content

Fix empty datetime range conversion #334

Description

@andreweuw

During, for example, batch query, when the user uploads an .xlsx file with empty values for From and Until, as, according to the Help tooltip, these fields are optional, results in the value parameter of _convert_to_dicom_date_time_datetime(value, vr_class) at

elif isinstance(value, tuple):

to be tuple(None, None), and later, replaced by empty strings and concatenated, becoming StudyDate=-, which does not correspond to any range syntax definition according to DICOM C.2.2.2.5.

Although some PACS may handle this parameter during, e.g., C-FIND well, other PACS may return a Successful DIMSE Status but no response identifiers, falsely missing all potential studies.

I suggest making the datetime conversion follow the definitions at C.2.2.2.5 more strictly to prevent C-FINDS from failing silently as described.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions