Open
Conversation
Don't cross-version with the target branch as that is the one we are trying to change. Signed-off-by: Ralph Castain <rhc@pmix.org>
Contributor
Author
|
bot:ibm:retest |
jjhursey
reviewed
Aug 2, 2022
| invalid_pairs.append([bld.branch,"v4.1"]) | ||
| invalid_tool_pairs.append([bld.branch,"v4.1"]) | ||
| invalid_pairs.append(["v4.1", bld.branch]) | ||
| invalid_tool_pairs.append(["v4.1", bld.branch]) |
Member
There was a problem hiding this comment.
Why not make a more general block outside of the selection logic like:
# Do not test the Build branch against the Target branch.
# If we are fixing cross-version issues then this is likely to fail which is correct in this circumstance.
invalid_pairs.append([bld.branch, target_branch])
invalid_pairs.append([target_branch, bld.branch])
invalid_tool_pairs.append([bld.branch, target_branch])
invalid_tool_pairs.append([target_branch, bld.branch])
Contributor
Author
There was a problem hiding this comment.
Yeah, I'm not entirely wild about this patch just yet. We don't want to test against the HEAD of the specific target branch as that is what we are changing, but we do want to test against any prior tagged releases in that branch to ensure we aren't breaking compatibility within the series. Still scratching my head over it. Your suggestion would indeed clean things up - just not sure yet what the logic should be to get what we really want.
Hope that makes some sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't cross-version with the target branch as that
is the one we are trying to change.
Signed-off-by: Ralph Castain rhc@pmix.org