Repository navigation
Conversation
With one session per executor in the chart's defaults, every session busy is the normal case, so a plan that found none free in a minute failed a teammate's run. Plan and apply now share one 10-minute creation timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Verified on Docker Desktop (#513): all three checks passHeads: #515 Setup:
1. Both pods Guaranteed, one 1536 MiB session: pass
2. A real 11-resource hashicorp/aws 6.x plan completes: pass
3. A second plan waits for the executor, then completes: pass
Everything is torn down: namespace, ingress-nginx, CoreDNS rewrite, the — Rahul (engineering) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #513.
Behaviour change
A plan now waits up to 10 minutes for a free executor session before it fails, the same as an apply. Before, a plan that found every session busy failed after 1 minute. With the chart's coming default of one session per executor, a busy slot is the normal case, so a teammate's plan would fail instead of waiting its turn.
planSessionCreationTimeout(1m) andapplySessionCreationTimeout(10m) become onesessionCreationTimeout = 10 * time.Minute, used by both phases. The run already records "waiting for executor" before the session is created; nothing else changes.docs/architecture.mdnow says 10-minute.No configuration or migration impact. Only the api image carries it (the api registers the workflows).
Replay
CreationTimeoutsets the SDK session-creation activity's schedule-to-start timeout: an activity option, not part of a command's identity, so in-flight histories should replay. Theworkflow-replayCI job on this PR is the evidence.Validation
Test first:
TestTemplateWorkflowsWaitTenMinutesForAnExecutorreads the creation timeout off the options the workflow schedules the SDK'sinternalSessionCreationActivitywith (through a workflow interceptor, sinceactivity.Infodoesn't carry schedule-to-start). Before the change:planfailed withsession creation timeouts = [1m0s], want [10m0s],applypassed. After: both pass.In a
golang:1.26Linux container:gofmt -l cmd internal: no outputgo vet ./internal/workflows/,go test ./internal/workflows/ -count=1: okgo test ./...: ok except the four tests ininternal/activitiesandinternal/sandboxthat fail only as root (Permission denied on the workspace);go test ./internal/activities/ ./internal/sandbox/as uid 1000: ok— Rahul (engineering)
🤖 Generated with Claude Code