Skip to content

docs(oe): fix stale docs and assert federator argument extraction - #585

Closed
ginaxu1 wants to merge 1 commit into
mainfrom
fix/513-oe-docs-and-weak-tests
Closed

ginaxu1 wants to merge 1 commit into
mainfrom
fix/513-oe-docs-and-weak-tests

Conversation

@ginaxu1

@ginaxu1 ginaxu1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • PROVIDER_CONFIGURATION.md: generated provider query requests fullName to match the @sourceInfo mapping.
  • HOW_TO_TEST.md: TC-009 title matches breaking-change result; TC-010–013 relabeled as PDP/CE gate tests (they never reach federation).
  • ConsumerAssertion.ApplicationID comment: mapped from validated client_id.
  • federator_test.go: assert len(response.Arguments) == expectedArgs.

Out of scope / follow-up

  • Audit disabled-path assertion from OE: stale/inaccurate documentation and weak test assertions #513 (len(receivedEvents) == 0 when IsEnabled() is false): blocked on Argus honoring the documented NewAuditMiddleware / InitializeGlobalAudit contract in middleware.
  • Depends on LSFLK/argus#16. After that merges and a pkg/audit release is cut, bump the Argus dependency here and add the assertion in TestLogAuditEventWhenNotConfigured.

Test plan

  • go test ./internal/oe/federator/ ./internal/oe/middleware/ ./internal/oe/auth/ -count=1

Closes #513

Align provider config and HOW_TO_TEST examples with actual behavior,
correct ConsumerAssertion ApplicationID comment, and assert
ProviderSchemaCollector Arguments length in table-driven tests.

Closes #513

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4faf20ea-4a18-453a-a28a-3b0cd91801db


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mushrafmim

Copy link
Copy Markdown
Member

Closing as superseded, thanks @ginaxu1. The parts it fixes were rewritten or removed in v0.5.0:

@mushrafmim mushrafmim closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OE: stale/inaccurate documentation and weak test assertions

2 participants