fix: make IPC listener lazy to avoid antivirus false positives - #429
Open
LopezDev7 wants to merge 1 commit into
Open
fix: make IPC listener lazy to avoid antivirus false positives#429LopezDev7 wants to merge 1 commit into
LopezDev7 wants to merge 1 commit into
Conversation
The IPC TCP listener was binding on startup which triggered AV detections (1-2/70 on VirusTotal). Now it only binds when joining a server, reducing detections to 0/67. Closes openmultiplayer#419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPC TCP listener was binding on startup which was triggering antivirus detections (ESET + Microsoft were flagging it on VirusTotal, 1-2/70). Made the listener lazy so it only opens when you actually join a server instead of on startup.
Ran both builds through VirusTotal:
Just moved the bind to right before DLL injection in the inject command, stored the app handle with a OnceLock so it's available when needed.
Closes #419