feat: skip-reconciliation annotation for object-based components#161
feat: skip-reconciliation annotation for object-based components#161AndresNico wants to merge 4 commits into
Conversation
|
The issue #156 says to create a follow-up ticket for how to solve this in V2 in service-provider-crossplane. Is that just supposed to be a reminder ticket or how detailed should that be? |
|
Thanks @AndresNico for this PR. I'll review it asap.
Since service-provider-crossplane is working the same way as in the control-plane-operator (via the |
|
I'll have a look into the failing GH Actions beginning next week 👀 |
|
@maximiliantech looks like setup-envtest is causing these problems. Apparently they switched away from using GCS bucket but setup-envtests in version release-0.16 still defaults to that location. (kubernetes-sigs/controller-runtime#2811) |
I created the ticket openmcp-project/service-provider-crossplane#129 |
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
87331fe to
1fdc4d7
Compare
What this PR does / why we need it:
This PR introduces an annotation
controlplane.core.orchestrate.cloud.sap/skip-reconciliationfor object-based components which will make the controller ignore existing resources during reconciliation when set totrue.Which issue(s) this PR fixes:
Fixes #156
Special notes for your reviewer:
Release note: