Repository navigation
fix(updater): check target branches before reset and clean up update config - #815
Merged
Merged
Conversation
…etting reset_repository already refused an auth commit that isn't on the default branch, but reset target repos to their recorded commit without checking that the commit is on the recorded branch. Run the same check for target repos in _perform_checks, before anything is reset.
…clude_filter UpdateConfig.checkout was set but never read. exclude_filter passed to a plain update was silently discarded in favor of the filter saved by the previous clone or update; log a warning so a mistaken call is visible.
n-dusan
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Closes #725
Closes #690
See the comment on #725
Code review checklist (for code reviewer to complete)