Skip to content

fix(updater): check target branches before reset and clean up update config - #815

Merged
renatav merged 4 commits into
masterfrom
renatav/reset-target-branch-check
Oct 9, 2026
Merged

renatav merged 4 commits into
masterfrom
renatav/reset-target-branch-check

Conversation

@renatav

@renatav renatav commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Description (e.g. "Related to ...", etc.)

Closes #725
Closes #690

See the comment on #725

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

…etting

reset_repository already refused an auth commit that isn't on the default
branch, but reset target repos to their recorded commit without checking
that the commit is on the recorded branch. Run the same check for target
repos in _perform_checks, before anything is reset.
…clude_filter

UpdateConfig.checkout was set but never read. exclude_filter passed to a
plain update was silently discarded in favor of the filter saved by the
previous clone or update; log a warning so a mistaken call is visible.
@renatav renatav changed the title Renatav/reset target branch check fix(updater): check target branches before reset and clean up update config Oct 9, 2026
@renatav
renatav requested a review from n-dusan October 9, 2026 14:32
@renatav
renatav merged commit 4b8f148 into master Oct 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate updater config types for clone, update, and validate Updater: implement branch check

2 participants