Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #606. When shutdown cancels a queued threaded request, its future callback removes an entry from
_request_futureswhilelsp_shutdownis iterating that dictionary. This raisesRuntimeError; the shutdown request receives an internal-error response and the protocol does not enter its shutdown state.Iterate a snapshot of the futures instead. The regression keeps one worker occupied, queues two more requests, then checks that shutdown succeeds, the queued requests are cancelled, and callback cleanup completes.
Validation
Local runs were on macOS; hosted CI will cover other platforms and versions.
uv lock --check --offlinefailed identically on base and this branch with local uv 0.13.1; the lockfile is unchanged. AI assistance was used to prepare and validate this change.