Add codespell support (config) and make it fix few typos#1364
Open
yarikoptic wants to merge 4 commits into
Open
Add codespell support (config) and make it fix few typos#1364yarikoptic wants to merge 4 commits into
yarikoptic wants to merge 4 commits into
Conversation
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i3 ./docs/editor_onboarding.md",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Contributor
|
This seems like a minimal maintenance burden thing, and since it is our publicly facing site (rather than correcting typos in code/comments that only programmers would see) it makes sense to me to have. Maybe one thing that might ease anxiety around maintenance burden might be to scope it to just the parts of the package that contain public-facing strings like the erb templates? But then again there are probably some of those throughout the ruby and js too so maybe thats more complicated than it's worth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
This is a reincarnated (no action this time) prior attempt
from a year ago, which shows that
superceded) which if already permeated to other places -- I guess ok to keep around , but otherwise ideally should have been fixed.@xuanxu mentions
which is I guess ok, but is there another level of assistance/automation to look adding it to?