Skip to content

8382166: [AOT Cache] CRC was not checked on Code Region#488

Draft
Delawen wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-Delawen-3dcd3653-master
Draft

8382166: [AOT Cache] CRC was not checked on Code Region#488
Delawen wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-Delawen-3dcd3653-master

Conversation

@Delawen
Copy link
Copy Markdown
Member

@Delawen Delawen commented Apr 21, 2026

Hi folks,

This pull request contains a backport of commit 3dcd3653 from the openjdk/jdk repository.

The commit being backported was authored by me (with a cherry pick of Ioi's test suggestion) on 21 Apr 2026 and was reviewed by Vladimir Kozlov, Ashutosh Mehra, Ioi Lam and Andrew Dinn.

While other regions check the CRC when loading the cache, the code cache region does not check it. This may bring issues with corrupted (or tainted) caches that load corrupted (or malicious) code into memory.

On this PR, we add a CRC check that cleans up memory if it fails.

Thanks!



Progress

  • Change must not contain extraneous whitespace
  • JDK-8382166 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8382166: [AOT Cache] CRC was not checked on Code Region (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/488/head:pull/488
$ git checkout pull/488

Update a local copy of the PR:
$ git checkout pull/488
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 488

View PR using the GUI difftool:
$ git pr show -t 488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/488.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 21, 2026

👋 Welcome back mariasde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 21, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 3dcd3653c82e92fc38f7725e5be78362a85ee39e 8382166: [AOT Cache] CRC was not checked on Code Region Apr 21, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 21, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 21, 2026
@Delawen
Copy link
Copy Markdown
Member Author

Delawen commented Apr 21, 2026

I will need to adapt the tests for the backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required

Development

Successfully merging this pull request may close these issues.

1 participant