Skip to content

8376969: Shenandoah: GC state getters should be inlineable#481

Closed
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:backport-JDK-8376969-to-jdk25u-dev
Closed

8376969: Shenandoah: GC state getters should be inlineable#481
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:backport-JDK-8376969-to-jdk25u-dev

Conversation

@earthling-amzn
Copy link
Copy Markdown

@earthling-amzn earthling-amzn commented Apr 16, 2026


Progress

  • Change must not contain extraneous whitespace
  • JDK-8376969 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8376969: Shenandoah: GC state getters should be inlineable (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/481/head:pull/481
$ git checkout pull/481

Update a local copy of the PR:
$ git checkout pull/481
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 481

View PR using the GUI difftool:
$ git pr show -t 481

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/481.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8376969: Shenandoah: GC state getters should be inlineable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 692444f071cab930d1b92bbfac79f87d0d801aab 8376969: Shenandoah: GC state getters should be inlineable Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 20, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 20, 2026

Webrevs

@earthling-amzn
Copy link
Copy Markdown
Author

/approval request This is relatively trivial change. It moves two small, but hot, methods into the inline header for performance improvements.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

@earthling-amzn
8376969: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 20, 2026
@earthling-amzn
Copy link
Copy Markdown
Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 23, 2026

Going to push as commit 962fd11.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 23, 2026
@openjdk openjdk Bot closed this Apr 23, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 23, 2026

@earthling-amzn Pushed as commit 962fd11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants