-
Notifications
You must be signed in to change notification settings - Fork 19
Update OAuth Section #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jischr
wants to merge
3
commits into
openid:main
Choose a base branch
from
jischr:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−6
Open
Update OAuth Section #325
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this partially answers the question in #327
It seems that OPRM (RFC 9728) is the only spec-defined in-band path from an SSF Transmitter URL to an Authorization Server.
Perhaps we should point the following interaction out more explicitly:
Discovery of OAuth Authorization Server from a SSF Transmitter issuer.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I agree, as the first subsection, we can have "Discovery of OAuth Authorization Server" to clarify some of those points. Let's make a new PR for that one.
The sections then flow nicely:
-> Discovery of AS
-> Authorization Grants
-> OAuth Scopes
-> Access Token Validation
Might require a bit of rework but may clear things up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasdarimont Can you explain the "It seems that OPRM (RFC 9728) is the only spec-defined in-band path from an SSF Transmitter URL to an Authorization Server." statement?
Can you also explain how you derive .well-known/oauth-protected-resource URL from a Transmitter URL? A transmitter URL can have a path so it can look like this: https:///.well-known/ssf-configuration/ssf/subscribers/5134159e-4fc8-48e2-8718-540d7f54ee56. Do you expect the OPRM URL to be https:///.well-known/oauth-protected-resource?
@jischr The interoperability spec mandate the usage of Oauth 2.0 for authorization. That shouldn't mean that we should be restrictive in how the Oauth 2.0 configuration is discovered. In order for a receiver to be able to get an access token, it needs to know the authorization or token endpoint. There are many ways to get those:
Is there a reason why we should explicitly specify only one of those options?