Repository navigation
Add hptwReservedAD regression test for reserved leaf PTE A/D updates - #1993
Merged
rosethompson merged 1 commit intoOct 19, 2026
Merged
Conversation
openhwfoundation#1916 stopped the page table walker from setting A/D on leaf PTEs with reserved encodings, but added no test. hptwReservedAD (from the closed openhwfoundation#1938) stores through leaves with PBMT=3, PBMT!=0 while menvcfg.PBMTE=0, a reserved NAPOT encoding and bit 54 set, and checks each takes a store page fault with the PTE unchanged, while legal PTEs still get A and D. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Harris <David_Harris@hmc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1916 fixed item 15 of #1921 (the page table walker set A/D on leaf PTEs with reserved PBMT, NAPOT or bits 60:54 before the store page fault) but added no test, and #1938, which had one, was closed as redundant. This adds that test,
tests/coverage/hptwReservedAD.S, which runs on rv64gc with the rest oftests/coverage: each reserved leaf must take a store page fault with the PTE unchanged, and legal PTEs (including PBMT=NC with PBMTE=1) must still get A and D. It fails if the walker'sLeafReservedFaultcheck is removed.🤖 Generated with Claude Code